Bug 149816 – http/tests/media/media-source/SourceBuffer-abort-updating.html is flaky

• Component: Tools / Tests
• Status: REOPENED

[Ryan Haddad]

http/tests/media/media-source/SourceBuffer-abort-updating.html is flaky, frequently crashing or timing out during test runs

http://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Fmedia%2Fmedia-source%2FSourceBuffer-abort-updating.html

[Ryan Haddad]

Correction: the crashes are only on GTK. Mac builds get timeouts and failures.

[Ryan Haddad]

Created attachment 262473 [details]
Patch

[Ryan Haddad]

http/tests/media/video-load-suspend.html timed out as well on the following build:
https://build.webkit.org/builders/Apple%20El%20Capitan%20Debug%20WK1%20(Tests)/builds/113

http/tests/media/media-source/mediasource-remove.html crashed on the following build:
https://build.webkit.org/builders/Apple%20Yosemite%20Release%20WK1%20(Tests)/builds/8830

Jer, is there anything bad hiding here?

[Jer Noble]

(In reply to comment #3)
> http/tests/media/video-load-suspend.html timed out as well on the following
> build:
> https://build.webkit.org/builders/
> Apple%20El%20Capitan%20Debug%20WK1%20(Tests)/builds/113
> 
> http/tests/media/media-source/mediasource-remove.html crashed on the
> following build:
> https://build.webkit.org/builders/Apple%20Yosemite%20Release%20WK1%20(Tests)/
> builds/8830

This is a crash in an underlying framework which was fixed in El Capitan.

> Jer, is there anything bad hiding here?

Can't say for sure. We'd need to get a spin log of the failing test to know for sure.  It could be that the test is crashing due to (one or more of) the above bug(s), but showing up as a timeout.

[Jer Noble]

(In reply to comment #4)
> (In reply to comment #3)
> > http/tests/media/video-load-suspend.html timed out as well on the following
> > build:
> > https://build.webkit.org/builders/
> > Apple%20El%20Capitan%20Debug%20WK1%20(Tests)/builds/113
> > 
> > http/tests/media/media-source/mediasource-remove.html crashed on the
> > following build:
> > https://build.webkit.org/builders/Apple%20Yosemite%20Release%20WK1%20(Tests)/
> > builds/8830
> 
> This is a crash in an underlying framework which was fixed in El Capitan.
> 
> > Jer, is there anything bad hiding here?
> 
> Can't say for sure. We'd need to get a spin log of the failing test to know
> for sure.  It could be that the test is crashing due to (one or more of) the
> above bug(s), but showing up as a timeout.

Oh I see, it's timing out on El Capitan as well as Yosemite.

[WebKit Commit Bot]

Comment on attachment 262473 [details]
Patch

Rejecting attachment 262473 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 262473, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
, u'Darin Adler']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Parsed 2 diffs from patch file(s).
patching file LayoutTests/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file LayoutTests/platform/mac/TestExpectations
Hunk #1 FAILED at 1331.
1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/mac/TestExpectations.rej

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Darin Adler']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/254497

[Ryan Haddad]

Created attachment 262711 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 262711 [details]
Patch

Clearing flags on attachment: 262711

Committed r190753: <http://trac.webkit.org/changeset/190753>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Ryan Haddad]

Leaving open for investigation

[Myles C. Maxfield]

Did this work? After this patch, http/tests/media/media-source/SourceBuffer-abort-updating.html seems to always fail on Mavericks.

https://build.webkit.org/builders/Apple%20Mavericks%20Release%20WK2%20(Tests)?numbuilds=50

[Myles C. Maxfield]

Seems that your new line is being used instead of the existing

[ Mavericks ] http/tests/media/media-source/ [ WontFix ]

[Blaze Burg]

Comment on attachment 262711 [details]
Patch

This expectation accidentally re-enables the test for Mavericks, where we have set !ENABLE(MEDIA_SESSION), so the test always fails.

[Blaze Burg]

Committed r190777: <http://trac.webkit.org/changeset/190777>