Bug 149786

Summary:

Support Trac 1.0.x XML timeline link format

Product:

WebKit

Reporter:

Alexey Proskuryakov <ap>

Component:

Tools / Tests

Assignee:

Alexey Proskuryakov <ap>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, lforschler

Priority:

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
proposed fix	none

Alexey Proskuryakov

Reported 2015-10-03 18:26:57 PDT

Make bot watcher's dashboard work with Trac 1.0.

Attachments
proposed fix (1.73 KB, patch) 2015-10-03 18:30 PDT, Alexey Proskuryakov	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Alexey Proskuryakov

Comment 1 2015-10-03 18:30:58 PDT

Created attachment 262384 [details] proposed fix

Lucas Forschler

Comment 2 2015-10-04 10:02:00 PDT

Comment on attachment 262384 [details] proposed fix This looks sufficient for when the revision number is the last, or next to last element in the linkComponents. If we find other cases where the revision number lies elsewhere, we might want to revisit a better regular expression.

WebKit Commit Bot

Comment 3 2015-10-04 10:49:37 PDT

Comment on attachment 262384 [details] proposed fix Clearing flags on attachment: 262384 Committed r190550: <http://trac.webkit.org/changeset/190550>

WebKit Commit Bot

Comment 4 2015-10-04 10:49:41 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.