Summary: | ShadowRoot with leading or trailing white space cause a crash | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> | ||||
Component: | DOM | Assignee: | Ryosuke Niwa <rniwa> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | cdumez, kling, koivisto, thorton | ||||
Priority: | P2 | ||||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 148695 | ||||||
Attachments: |
|
Description
Ryosuke Niwa
2015-10-02 18:46:26 PDT
Created attachment 262375 [details]
Fixes the crash
ping? Comment on attachment 262375 [details] Fixes the crash View in context: https://bugs.webkit.org/attachment.cgi?id=262375&action=review r=me with comments. > Source/WebCore/style/RenderTreePosition.cpp:66 > + if (PseudoElement* before = parent->beforePseudoElement()) auto* > LayoutTests/fast/shadow-dom/shadow-root-with-child-whitespace-text-crash.html:14 > +host.attachShadow({mode: 'closed'}).innerHTML = ` <slot></slot> `; Why are the quotes around the value so weird? Committed r190585: <http://trac.webkit.org/changeset/190585> |