Bug 149739

Summary:

Inserting a child to a slot assigned node doesn't trigger repaint

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

Layout and Rendering

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, commit-queue, esprehn+autocc, hyatt, kangil.han, koivisto, rniwa, ryanhaddad, thorton, zalan

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

148695

Attachments:

Description	Flags
Demo	none
patch	buildbot: commit-queue-
Archive of layout-test-results from ews103 for mac-mavericks	none
test fix	none

Description Ryosuke Niwa 2015-10-01 21:08:53 PDT

When you insert a child to a node assigned to a slot, we don't trigger a repaint.

Comment 1 Ryosuke Niwa 2015-10-01 21:10:19 PDT

Created attachment 262314 [details]
Demo

Comment 2 Antti Koivisto 2015-10-02 07:39:31 PDT

Created attachment 262330 [details]
patch

Comment 3 Build Bot 2015-10-02 08:12:17 PDT

Comment on attachment 262330 [details]
patch

Attachment 262330 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/236636

New failing tests:
fast/shadow-dom/insert-child-to-assigned-node.html

Comment 4 Build Bot 2015-10-02 08:12:23 PDT

Created attachment 262331 [details]
Archive of layout-test-results from ews103 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-mavericks  Platform: Mac OS X 10.9.5

Comment 5 Antti Koivisto 2015-10-02 14:08:58 PDT

Created attachment 262349 [details]
test fix

Comment 6 WebKit Commit Bot 2015-10-02 16:32:58 PDT

Comment on attachment 262349 [details]
test fix

Clearing flags on attachment: 262349

Committed r190530: <http://trac.webkit.org/changeset/190530>

Comment 7 WebKit Commit Bot 2015-10-02 16:33:04 PDT

All reviewed patches have been landed.  Closing bug.

Comment 8 Alexey Proskuryakov 2015-10-02 21:58:45 PDT

fast/shadow-dom/insert-child-to-assigned-node.html times out on Windows, Gtk and Efl every time.

Comment 9 Ryosuke Niwa 2015-10-03 00:03:58 PDT

(In reply to comment #8)
> fast/shadow-dom/insert-child-to-assigned-node.html times out on Windows, Gtk
> and Efl every time.

Oh oops, I guess notifyDone is never called on those platforms because we throw an exception :( Will fix. Thanks for letting me know.

Comment 10 Ryosuke Niwa 2015-10-03 03:15:14 PDT

Fixed the test in https://trac.webkit.org/changeset/190544.