Summary: | Moving cursor down in contentEditable section fails if styled line-height:1em | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | ben <ben> | ||||||
Component: | HTML Editing | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bdakin, ben, hyatt, mitz | ||||||
Priority: | P2 | Keywords: | HasReduction, InRadar | ||||||
Version: | 523.x (Safari 3) | ||||||||
Hardware: | Mac | ||||||||
OS: | OS X 10.4 | ||||||||
Attachments: |
|
Description
ben
2007-08-15 07:46:48 PDT
Created attachment 15979 [details]
html file illustrating problem
Confirmed with a local debug build of WebKit r25066 with Safari 3 Public Beta v. 3.0.3 (522.12.1) on Mac OS X 10.4.10 (8R218). This also reproduces on Safari 2.0.4 (419.3) with its original WebKit on 10.4.10, so it's not a regression. Also note the "lip" at the bottom of the <iframe> which bleeds through contents of the iframe! That looks like a different bug, although it's also present on Safari 2.0.4 as well. Created attachment 15984 [details]
Change RenderText hit testing to prefer the lower of two overlapping lines
No layout test regressions, but it is perhaps worth mentioning that a more local fix is possible by patching nextLinePosition() to pass a lower y coordinate to positionForCoordinates().
Comment on attachment 15984 [details]
Change RenderText hit testing to prefer the lower of two overlapping lines
r=me
|