Bug 149715
| Summary: | built-product-archive assumes 32-bit Windows build | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Daniel Bates <dbates> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | Normal | CC: | achristensen, bfulgham, lforschler, ross.kirsling |
| Priority: | P2 | Keywords: | PlatformOnly |
| Version: | WebKit Local Build | ||
| Hardware: | PC | ||
| OS: | All | ||
Daniel Bates
In attempting to fix the Windows build breakage (*) following the patch for bug #149695, I noticed that built-product-archive hardcoded the assumption that we build 32-bit Windows. In particular, it looks for the built products to be in the subdirectory bin32 of the top-level WebKit build directory. We should make use of the configuration-specific build directory returned by the script webkit-build-directory (as we do for other ports) instead of hardcoding the path to the subdirectory bin32 for Windows.
(*) Windows build fix committed in <http://trac.webkit.org/changeset/190411>.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Brent Fulgham
I think this is complicated by the fact that Windows creates 32-bit and 64-bit subdirectories, which other platforms don't do.
Maybe I should add another flag to "webkit-build-directory" to return the active configuration (32-bit or 64-bit), or to return the full path to the binaries (perhaps only to be used under Windows)?
Ross Kirsling
*** This bug has been marked as a duplicate of bug 184715 ***