Bug 14970 – Please clarify licensing for some files

• Component: WebKit Misc.
• Status: RESOLVED FIXED

[Mike Hommey]

The following files are © Apple, All rights reserved, with no further licensing information:
WebCore/bindings/objc/WebScriptObject.h
WebCore/bindings/objc/WebScriptObjectInternal.h
WebCore/bindings/objc/WebScriptObjectPrivate.h
Please add the proper licensing terms in the header. I guess it should be:
Redistribution and use in source and binary forms, with or without
modification, are permitted provided that the following conditions
are met:
1. Redistributions of source code must retain the above copyright
   notice, this list of conditions and the following disclaimer.
2. Redistributions in binary form must reproduce the above copyright
   notice, this list of conditions and the following disclaimer in the
   documentation and/or other materials provided with the distribution.

THIS SOFTWARE IS PROVIDED BY APPLE COMPUTER, INC. ``AS IS'' AND ANY
EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
PURPOSE ARE DISCLAIMED.  IN NO EVENT SHALL APPLE COMPUTER, INC. OR
CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

[Mike Hommey]

The same applies to the following files:
WebCore/platform/mac/ShapeArabic.c
WebKit/Plugins/WebNetscapeDeprecatedFunctions.c
WebKit/Plugins/WebNetscapeDeprecatedFunctions.h

The following files have no copyright notice, and include licensing terms quite similar but not exactly the 3-clause BSD-like license applied to a lot of the files in the tree.
WebKitTools/DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/main.c
WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c
WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h
WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c
WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.h
WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/main.c

Files under WebKitTools/mangleme are © Michal Zalewski <[e-mail]> and have no licensing terms.

[Darin Adler]

I'm not sure it's an absolute requirement to put a copy of the licensing terms into each source file. But since it makes things clearer, it's worth doing.

For the copy of mangleme, I'm not sure it's appropriate for us to modify our copy of these files to add the license, since we're not the copyright holders. Instead we should put the appropriate license into a LICENSE file in that directory.

[Mike Hommey]

(In reply to comment #2)
> I'm not sure it's an absolute requirement to put a copy of the licensing terms
> into each source file. But since it makes things clearer, it's worth doing.

FWIW, the main thing that makes it unclear is that there is a copyright statement in the files, but no licensing terms.

> For the copy of mangleme, I'm not sure it's appropriate for us to modify our
> copy of these files to add the license, since we're not the copyright holders.
> Instead we should put the appropriate license into a LICENSE file in that
> directory.

You're probably free to add the licensing terms to the files as soon as you are not changing upstream's licensing terms. Anyways, a LICENSE file will surely be enough. According to freshmeat, it's LGPL.

[Mike Hommey]

WebKit/mac/Plugins/WebNetscapeDeprecatedFunctions.[ch] are recent additions that would also benefit from license clarification.

[Mike Hommey]

WebCore/platform/text/mac/ShapeArabic.c, too.

[David Kilzer (:ddkilzer)]

(In reply to comment #3)
> (In reply to comment #2)
> > For the copy of mangleme, I'm not sure it's appropriate for us to modify our
> > copy of these files to add the license, since we're not the copyright holders.
> > Instead we should put the appropriate license into a LICENSE file in that
> > directory.
> 
> You're probably free to add the licensing terms to the files as soon as you are
> not changing upstream's licensing terms. Anyways, a LICENSE file will surely be
> enough. According to freshmeat, it's LGPL.

http://www.gnu.org/licenses/lgpl-2.1.html

[David Kilzer (:ddkilzer)]

Created attachment 19294 [details]
Patch v1

Add/update copyright statements and licenses as appropriate.

[Darin Adler]

Comment on attachment 19294 [details]
Patch v1

I normally only use one space after "Apple Inc." before "All rights reserved".

r=me

[David Kilzer (:ddkilzer)]

(In reply to comment #8)
> (From update of attachment 19294 [details] [edit])
> I normally only use one space after "Apple Inc." before "All rights reserved".

Fixed.

Committed revision 30520.