Summary: | Please clarify licensing for some files | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mike Hommey <mh+webkit> | ||||
Component: | WebKit Misc. | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | ddkilzer | ||||
Priority: | P2 | ||||||
Version: | 523.x (Safari 3) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Mike Hommey
2007-08-15 03:12:59 PDT
The same applies to the following files: WebCore/platform/mac/ShapeArabic.c WebKit/Plugins/WebNetscapeDeprecatedFunctions.c WebKit/Plugins/WebNetscapeDeprecatedFunctions.h The following files have no copyright notice, and include licensing terms quite similar but not exactly the 3-clause BSD-like license applied to a lot of the files in the tree. WebKitTools/DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/main.c WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.h WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/main.c Files under WebKitTools/mangleme are © Michal Zalewski <lcamtuf@coredump.cx> and have no licensing terms. I'm not sure it's an absolute requirement to put a copy of the licensing terms into each source file. But since it makes things clearer, it's worth doing. For the copy of mangleme, I'm not sure it's appropriate for us to modify our copy of these files to add the license, since we're not the copyright holders. Instead we should put the appropriate license into a LICENSE file in that directory. (In reply to comment #2) > I'm not sure it's an absolute requirement to put a copy of the licensing terms > into each source file. But since it makes things clearer, it's worth doing. FWIW, the main thing that makes it unclear is that there is a copyright statement in the files, but no licensing terms. > For the copy of mangleme, I'm not sure it's appropriate for us to modify our > copy of these files to add the license, since we're not the copyright holders. > Instead we should put the appropriate license into a LICENSE file in that > directory. You're probably free to add the licensing terms to the files as soon as you are not changing upstream's licensing terms. Anyways, a LICENSE file will surely be enough. According to freshmeat, it's LGPL. WebKit/mac/Plugins/WebNetscapeDeprecatedFunctions.[ch] are recent additions that would also benefit from license clarification. WebCore/platform/text/mac/ShapeArabic.c, too. (In reply to comment #3) > (In reply to comment #2) > > For the copy of mangleme, I'm not sure it's appropriate for us to modify our > > copy of these files to add the license, since we're not the copyright holders. > > Instead we should put the appropriate license into a LICENSE file in that > > directory. > > You're probably free to add the licensing terms to the files as soon as you are > not changing upstream's licensing terms. Anyways, a LICENSE file will surely be > enough. According to freshmeat, it's LGPL. http://www.gnu.org/licenses/lgpl-2.1.html Created attachment 19294 [details]
Patch v1
Add/update copyright statements and licenses as appropriate.
Comment on attachment 19294 [details]
Patch v1
I normally only use one space after "Apple Inc." before "All rights reserved".
r=me
(In reply to comment #8) > (From update of attachment 19294 [details] [edit]) > I normally only use one space after "Apple Inc." before "All rights reserved". Fixed. Committed revision 30520. |