Summary: | JetStream timeout should long enough for slow device. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | dewei_zhu | ||||
Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED CONFIGURATION CHANGED | ||||||
Severity: | Normal | CC: | ahmad.saleem792, commit-queue, dewei_zhu, glenn, rniwa | ||||
Priority: | P2 | ||||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
dewei_zhu
2015-09-30 16:17:31 PDT
Created attachment 262201 [details]
Patch
Attachment 262201 [details] did not pass style-queue:
ERROR: Tools/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5]
Total errors found: 1 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 262201 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=262201&action=review rs=me with comments. > Tools/ChangeLog:3 > + Extend JetStream timeout for slow device. "devices" > Tools/ChangeLog:7 > + Extend JetStream timeout to 20 minites. "minutes" Already increased to patch time: https://github.com/WebKit/WebKit/blob/main/Tools/Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan#L2 but it landed due to some other patch since when I tried to search with this bug ID, it was not in Commit history on Webkit GitHub. Marking this as "RESOLVED CONFIGURATION CHANGED", since needed change is already done. Thanks! |