Bug 149640 – configure-xcode-for-ios-development does not work with Xcode 7

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Daniel Bates]

Running `sudo configure-xcode-for-ios-development` dies with an error because it cannot find the iOS specification files in the Xcode 7 distribution.

[Daniel Bates]

Created attachment 262098 [details]
Patch

[Alexey Proskuryakov]

Comment on attachment 262098 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=262098&action=review

> Tools/Scripts/configure-xcode-for-ios-development:112
> +    if (updateXcode7SpecificationFileForSDKIfNeeded($sdkName)) {
> +        return;
> +    }
> +    createLegacyXcodeSpecificationFilesForSDKIfNeeded($sdkName);

This is not a great way to structure the code - we try Xcode 7 code path, and it it fails for any reason, we fall back. But it's really unclear that the only possible failure is when it's an older Xcode.

> Tools/Scripts/configure-xcode-for-ios-development:226
> +    if ($mode == TRUNCATE_FILE) {

I don't think that passing a mode is necessary. This function can check for the file's existence.

[Daniel Bates]

Created attachment 262110 [details]
Patch

[Build Bot]

Comment on attachment 262110 [details]
Patch

Attachment 262110 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/224835

New failing tests:
http/tests/websocket/tests/hybi/workers/no-onmessage-in-sync-op.html

[Build Bot]

Created attachment 262113 [details]
Archive of layout-test-results from ews102 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-mavericks  Platform: Mac OS X 10.9.5

[Daniel Bates]

Comment on attachment 262110 [details]
Patch

Clearing flags on attachment: 262110

Committed r190333: <http://trac.webkit.org/changeset/190333>

[Daniel Bates]

All reviewed patches have been landed.  Closing bug.