Bug 149606

Summary:

Memory cache revalidations should refresh the network disk cache

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

WebKit2

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, barraclough, buildbot, cgarcia, commit-queue, koivisto, rniwa

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews107 for mac-mavericks-wk2	none
Patch	none
Archive of layout-test-results from ews104 for mac-mavericks-wk2	none
Patch	none

Chris Dumez

Reported 2015-09-28 15:04:17 PDT

Memory cache revalidations should refresh the network disk cache. They currently bypass the disk cache entirely and don't update the disk cache. This means that the memory cache can end up with fresher resources than the disk cache.

Attachments
Patch (7.77 KB, patch) 2015-09-28 21:02 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews107 for mac-mavericks-wk2 (706.59 KB, application/zip) 2015-09-28 21:58 PDT, Build Bot	no flags	Details
Patch (7.77 KB, patch) 2015-09-29 09:28 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews104 for mac-mavericks-wk2 (662.95 KB, application/zip) 2015-09-29 10:06 PDT, Build Bot	no flags	Details
Patch (9.90 KB, patch) 2015-09-29 10:49 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Chris Dumez

Comment 1 2015-09-28 21:02:44 PDT

Created attachment 262039 [details] Patch

Build Bot

Comment 2 2015-09-28 21:58:47 PDT

Comment on attachment 262039 [details] Patch Attachment 262039 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/222334 New failing tests: http/tests/xmlhttprequest/cache-override.html

Build Bot

Comment 3 2015-09-28 21:58:51 PDT

Created attachment 262041 [details] Archive of layout-test-results from ews107 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5

Chris Dumez

Comment 4 2015-09-29 09:28:03 PDT

Created attachment 262071 [details] Patch

Build Bot

Comment 5 2015-09-29 10:06:29 PDT

Comment on attachment 262071 [details] Patch Attachment 262071 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/224025 New failing tests: http/tests/xmlhttprequest/cache-override.html

Build Bot

Comment 6 2015-09-29 10:06:34 PDT

Created attachment 262076 [details] Archive of layout-test-results from ews104 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5

Chris Dumez

Comment 7 2015-09-29 10:16:41 PDT

(In reply to comment #5) > Comment on attachment 262071 [details] > Patch > > Attachment 262071 [details] did not pass mac-wk2-ews (mac-wk2): > Output: http://webkit-queues.webkit.org/results/224025 > > New failing tests: > http/tests/xmlhttprequest/cache-override.html I was wondering why this test is not failing locally: LayoutTests/platform/mac/TestExpectations:[ Yosemite+ ] http/tests/xmlhttprequest/cache-override.html [ Failure ]

Chris Dumez

Comment 8 2015-09-29 10:49:01 PDT

Created attachment 262079 [details] Patch

WebKit Commit Bot

Comment 9 2015-09-29 12:04:43 PDT

Comment on attachment 262079 [details] Patch Clearing flags on attachment: 262079 Committed r190320: <http://trac.webkit.org/changeset/190320>

WebKit Commit Bot

Comment 10 2015-09-29 12:04:49 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.