Bug 149605 – Bring El Capitan buildbot infrastructure online

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Lucas Forschler]

Prepare for the future by adding El Capitan infrastructure.
We should not commit and update the master until El Capitan is available.

[Radar WebKit Bug Importer]

<rdar://problem/22886617>

[Lucas Forschler]

Created attachment 262094 [details]
Bring El Capitan buildbot infrastructure online

We will update the buildbot master and restart it once Capitan is available to the world.

[Lucas Forschler]

Comment on attachment 262094 [details]
Bring El Capitan buildbot infrastructure online

View in context: https://bugs.webkit.org/attachment.cgi?id=262094&action=review

notes from Alexey

> Tools/BuildSlaveSupport/build.webkit.org-config/config.json:87
> +                      "triggers": ["elcapitan-debug-tests-jsc", "elcapitan-debug-tests-wk1", "elcapitan-debug-tests-wk2", "elcapitan-leaks"],

ap: make this run on release instead of debug

> Tools/BuildSlaveSupport/build.webkit.org-config/config.json:109
> +                      "platform": "mac-elcapitan", "configuration": "debug", "architectures": ["x86_64"],

ap: should be 32 bit arch

> Tools/BuildSlaveSupport/build.webkit.org-config/config.json:137
> +                      "platform": "mac-elcapitan", "configuration": "debug", "architectures": ["x86_64"],

ap: make this release

[Lucas Forschler]

Created attachment 262097 [details]
Add El Capitan OpenSource buildbot configuration

Updates from feedback

[Csaba Osztrogonác]

(In reply to comment #4)
> Created attachment 262097 [details]
> Add El Capitan OpenSource buildbot configuration
> 
> Updates from feedback

Please add expected results for these new bots 
in mastercfg_unittest.py - expected_build_steps

[Csaba Osztrogonác]

Comment on attachment 262097 [details]
Add El Capitan OpenSource buildbot configuration

View in context: https://bugs.webkit.org/attachment.cgi?id=262097&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/config.json:116
> +                    { "name": "Apple El Capitan Release (Build)", "type": "Build", "builddir": "elcapitan-release",
> +                      "platform": "mac-elcapitan", "configuration": "release", "architectures": ["x86_64"],
> +                      "triggers": ["elcapitan-release-tests-jsc", "elcapitan-release-tests-wk1", "elcapitan-release-tests-wk2", "elcapitan-release-perf", "elcapitan-leaks"],
> +                      "slavenames": ["bot417", "bot418"]
> +                    },

The leak bot should be triggered by the debug builder instead of the release one.

[Alexey Proskuryakov]

> The leak bot should be triggered by the debug builder instead of the release one.

Can you elaborate? Leaks tests should work fine in release Mac builds, thanks to bmalloc disabling itself (although I haven't tried that).

[Lucas Forschler]

Created attachment 262121 [details]
El Capitan Buildbot Config plus unittest

Added unit tests for El Capitan.

[Alexey Proskuryakov]

Comment on attachment 262121 [details]
El Capitan Buildbot Config plus unittest

View in context: https://bugs.webkit.org/attachment.cgi?id=262121&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/config.json:137
> +                      "platform": "mac-elcapitan", "configuration": "debug", "architectures": ["x86_64"],

Should be configuration: release.

[Lucas Forschler]

Created attachment 262150 [details]
El Capitan buildbot configuration

Fix debug->release for Leaks

[Csaba Osztrogonác]

(In reply to comment #7)
> > The leak bot should be triggered by the debug builder instead of the release one.
> 
> Can you elaborate? Leaks tests should work fine in release Mac builds,
> thanks to bmalloc disabling itself (although I haven't tried that).

I just saw the Yosemite configuration of the bots and the leak bot is 
triggered by the debug builder. I thought we need the same configuration.

[WebKit Commit Bot]

Comment on attachment 262150 [details]
El Capitan buildbot configuration

Clearing flags on attachment: 262150

Committed r190348: <http://trac.webkit.org/changeset/190348>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.