Bug 149552

Summary: Clean up all uses of PassRefPtr in Modules/geolocation
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: New BugsAssignee: Gyuyoung Kim <gyuyoung.kim>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 144092    
Attachments:
Description Flags
Patch
none
Patch none

Gyuyoung Kim
Reported 2015-09-25 01:00:07 PDT
SSIA
Attachments
Patch (13.80 KB, patch)
2015-09-25 01:01 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Patch (13.88 KB, patch)
2015-09-30 21:33 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1 2015-09-25 01:01:03 PDT
Created attachment 261917 [details] Patch
Darin Adler
Comment 2 2015-09-30 21:19:05 PDT
Comment on attachment 261917 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=261917&action=review > Source/WebCore/Modules/geolocation/Geoposition.h:45 > return Geoposition::create(m_coordinates->isolatedCopy(), m_timestamp); Could just be create, not Geoposition::create.
Gyuyoung Kim
Comment 3 2015-09-30 21:33:23 PDT
Created attachment 262229 [details] Patch
Gyuyoung Kim
Comment 4 2015-09-30 23:35:53 PDT
(In reply to comment #2) > Comment on attachment 261917 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=261917&action=review > > > Source/WebCore/Modules/geolocation/Geoposition.h:45 > > return Geoposition::create(m_coordinates->isolatedCopy(), m_timestamp); > > Could just be create, not Geoposition::create. Thanks. Done.
WebKit Commit Bot
Comment 5 2015-10-01 00:23:17 PDT
Comment on attachment 262229 [details] Patch Clearing flags on attachment: 262229 Committed r190391: <http://trac.webkit.org/changeset/190391>
WebKit Commit Bot
Comment 6 2015-10-01 00:23:21 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.