Summary: | [Win] Support composited content in WebView render-to-context methods | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brent Fulgham <bfulgham> | ||||
Component: | Layout and Rendering | Assignee: | Brent Fulgham <bfulgham> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | bfulgham, commit-queue, simon.fraser, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Brent Fulgham
2015-09-23 22:02:21 PDT
Created attachment 261862 [details]
Patch
Comment on attachment 261862 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=261862&action=review > Source/WebKit/win/WebView.cpp:6165 > + ::ValidateRect(m_viewWindow, nullptr); Is it correct to validate a rect in the window when you may be painting into an unrelated DC? > Source/WebKit/win/WebView.cpp:6192 > + ::ValidateRect(m_viewWindow, nullptr); Ditto. Also why isn't this code shared? Comment on attachment 261862 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=261862&action=review >> Source/WebKit/win/WebView.cpp:6165 >> + ::ValidateRect(m_viewWindow, nullptr); > > Is it correct to validate a rect in the window when you may be painting into an unrelated DC? I think you are right. This should not be used here. >> Source/WebKit/win/WebView.cpp:6192 >> + ::ValidateRect(m_viewWindow, nullptr); > > Ditto. Also why isn't this code shared? It should be. I'll revise that. Committed r190235: <http://trac.webkit.org/changeset/190235> |