Bug 149513

Summary: git-add-reviewer should trim trailing spaces/newlines
Product: WebKit Reporter: Anshu Chimala <anshu>
Component: Tools / TestsAssignee: Dana Burkart <dburkart>
Status: RESOLVED FIXED    
Severity: Enhancement CC: dburkart, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Chomp trailing whitespace from the reviewer argument darin: review+

Anshu Chimala
Reported 2015-09-23 17:31:56 PDT
I typed git add-reviewer HEAD "Reviewer Name then accidentally hit return without closing my end quote. I typed the end quote on the next line, assuming that the script would trim the newline at the end. It didn't. I ended up with my ChangeLog looking like: Reviewed by Reviewer Name . It would be nice if the script could avoid doing this.
Attachments
Chomp trailing whitespace from the reviewer argument (1.41 KB, patch)
2015-09-29 11:52 PDT, Dana Burkart 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dana Burkart
Comment 1 2015-09-23 17:33:38 PDT
rdar://problem/22809451
Dana Burkart
Comment 2 2015-09-29 11:52:13 PDT
Created attachment 262085 [details] Chomp trailing whitespace from the reviewer argument
Dana Burkart
Comment 3 2015-09-30 13:06:23 PDT
Committed r190366
Note You need to log in before you can comment on or make changes to this bug.