Bug 149490

Summary:

Range's setStartBefore() / setStartAfter() / setEndBefore() / setEndAfter() do not match the specification

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

DOM

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, darin, esprehn+autocc, kangil.han, rniwa, webkit-bug-importer

Priority:

Keywords:

InRadar, WebExposed

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Chris Dumez

Reported 2015-09-22 20:51:57 PDT

Range's setStartBefore() / setStartAfter() / setEndBefore() / setEndAfter() do not match the specification: - https://dom.spec.whatwg.org/#dom-range-setstartbefore - https://dom.spec.whatwg.org/#dom-range-setstartafter - https://dom.spec.whatwg.org/#dom-range-setendbefore - https://dom.spec.whatwg.org/#dom-range-setendafter In particular, instead of step 2: "If parent is null, throw an InvalidNodeTypeError exception." Our implementation does more checks and throws exceptions in cases that the specification does not say we should. Firefox's behavior matches the specification.

Attachments
Patch (26.91 KB, patch) 2015-09-22 20:58 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.