Summary: | [WK1] Null dereference loading Blink layout test editing/input/text-input-controller-no-editable-no-crash.html | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jon Honeycutt <jhoneycutt> | ||||||||||
Component: | HTML Editing | Assignee: | Jiewen Tan <jiewen_tan> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | bfulgham, commit-queue, jiewen_tan, webkit-bug-importer | ||||||||||
Priority: | P2 | Keywords: | BlinkMergeCandidate, HasReduction, InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Jon Honeycutt
2015-09-22 16:42:37 PDT
Created attachment 264626 [details]
Patch
Created attachment 264627 [details]
Patch
Comment on attachment 264627 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=264627&action=review > Source/WebKit/mac/WebView/WebFrame.mm:811 > + if (!_private->coreFrame->selection().rootEditableElementOrDocumentElement()) > + return 0; This is such a long expression, I suggest putting the result into a local variable. This is an Objective-C object pointer, so I suggest returning nil, not 0. Created attachment 264721 [details]
Patch for committing
Comment on attachment 264721 [details] Patch for committing Clearing flags on attachment: 264721 Committed r192007: <http://trac.webkit.org/changeset/192007> |