Bug 149476

Summary: Range.surroundContents() should check for partially contained non-Text nodes first
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, darin, esprehn+autocc, kangil.han, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar, WebExposed
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
URL: https://dom.spec.whatwg.org/#dom-range-surroundcontents
Attachments:
Description Flags
Patch none

Description Chris Dumez 2015-09-22 14:58:00 PDT 
Range.surroundContents() should check for partially contained non-Text nodes first, before checking the type of the newParent parameter:
https://dom.spec.whatwg.org/#dom-range-surroundcontents (step 1 and 2)

Firefox and Chrome follow the specification.
Comment 1 Chris Dumez 2015-09-22 15:02:51 PDT 
Created attachment 261767 [details]
Patch
Comment 2 WebKit Commit Bot 2015-09-22 16:15:16 PDT 
Comment on attachment 261767 [details]
Patch

Clearing flags on attachment: 261767

Committed r190139: <http://trac.webkit.org/changeset/190139>
Comment 3 WebKit Commit Bot 2015-09-22 16:15:22 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2015-09-28 11:41:37 PDT 
<rdar://problem/22882532>