Bug 149476

Summary: Range.surroundContents() should check for partially contained non-Text nodes first
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, darin, esprehn+autocc, kangil.han, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar, WebExposed
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
URL: https://dom.spec.whatwg.org/#dom-range-surroundcontents
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2015-09-22 14:58:00 PDT
Range.surroundContents() should check for partially contained non-Text nodes first, before checking the type of the newParent parameter: https://dom.spec.whatwg.org/#dom-range-surroundcontents (step 1 and 2) Firefox and Chrome follow the specification.
Attachments
Patch (55.22 KB, patch)
2015-09-22 15:02 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2015-09-22 15:02:51 PDT
Created attachment 261767 [details] Patch
WebKit Commit Bot
Comment 2 2015-09-22 16:15:16 PDT
Comment on attachment 261767 [details] Patch Clearing flags on attachment: 261767 Committed r190139: <http://trac.webkit.org/changeset/190139>
WebKit Commit Bot
Comment 3 2015-09-22 16:15:22 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4 2015-09-28 11:41:37 PDT
<rdar://problem/22882532>
Note You need to log in before you can comment on or make changes to this bug.