Summary: | the toInt32 operation inside DFGSpeculativeJIT.cpp can't throw so we shouldn't emit an exceptionCheck after it. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Saam Barati <saam> | ||||
Component: | JavaScriptCore | Assignee: | Saam Barati <saam> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | benjamin, commit-queue, fpizlo, ggaren, gskachkov, keith_miller, mark.lam, msaboff, oliver, sukolsak, ysuzuki | ||||
Priority: | P2 | ||||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Saam Barati
2015-09-22 10:29:19 PDT
Created attachment 261750 [details]
patch
Comment on attachment 261750 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=261750&action=review > Source/JavaScriptCore/dfg/DFGCommonData.cpp:62 > + RELEASE_ASSERT(codeOrigins.size()); I think moving this to a RELEASE_ASSERT should help us find any remaining callOperation call sites that also run into this problem. Comment on attachment 261750 [details]
patch
r=me
Comment on attachment 261750 [details] patch Clearing flags on attachment: 261750 Committed r190128: <http://trac.webkit.org/changeset/190128> All reviewed patches have been landed. Closing bug. |