Summary: | Always use the compiler's CAS implementation and get rid of ENABLE(COMPARE_AND_SWAP) | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Filip Pizlo <fpizlo> | ||||||||
Component: | Web Template Framework | Assignee: | Filip Pizlo <fpizlo> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | barraclough, benjamin, cmarcelo, commit-queue, ggaren, mark.lam, mhahnenb, msaboff, nrotem, oliver, saam, sam | ||||||||
Priority: | P2 | ||||||||||
Version: | Other | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 149436 | ||||||||||
Attachments: |
|
Description
Filip Pizlo
2015-09-21 18:05:18 PDT
Created attachment 261710 [details]
the patch
Created attachment 261712 [details]
the patch
Comment on attachment 261712 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=261712&action=review r=me with build fix. > Source/WebCore/platform/text/TextBreakIterator.cpp:815 > return WTF::weakCompareAndSwap(reinterpret_cast<void**>(&nonSharedCharacterBreakIterator), expected, newValue); I think if you remove the reinterpret_cast here, the build breakage will be fixed. (In reply to comment #3) > Comment on attachment 261712 [details] > the patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=261712&action=review > > r=me with build fix. > > > Source/WebCore/platform/text/TextBreakIterator.cpp:815 > > return WTF::weakCompareAndSwap(reinterpret_cast<void**>(&nonSharedCharacterBreakIterator), expected, newValue); > > I think if you remove the reinterpret_cast here, the build breakage will be > fixed. Yup, that worked! Created attachment 261719 [details]
patch for landing
Landed in http://trac.webkit.org/changeset/190103 |