Bug 149438

Summary: Always use the compiler's CAS implementation and get rid of ENABLE(COMPARE_AND_SWAP)
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: Web Template FrameworkAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, benjamin, cmarcelo, commit-queue, ggaren, mark.lam, mhahnenb, msaboff, nrotem, oliver, saam, sam
Priority: P2    
Version: Other   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 149436    
Attachments:
Description Flags
the patch
none
the patch
mark.lam: review+
patch for landing none

Filip Pizlo
Reported 2015-09-21 18:05:18 PDT
Patch forthcoming.
Attachments
the patch (12.60 KB, patch)
2015-09-21 18:12 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (13.21 KB, patch)
2015-09-21 18:29 PDT, Filip Pizlo 		mark.lam: review+
DetailsFormatted DiffDiff
patch for landing (13.29 KB, patch)
2015-09-21 21:01 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2015-09-21 18:12:55 PDT
Created attachment 261710 [details] the patch
Filip Pizlo
Comment 2 2015-09-21 18:29:51 PDT
Created attachment 261712 [details] the patch
Mark Lam
Comment 3 2015-09-21 19:33:25 PDT
Comment on attachment 261712 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=261712&action=review r=me with build fix. > Source/WebCore/platform/text/TextBreakIterator.cpp:815 > return WTF::weakCompareAndSwap(reinterpret_cast<void**>(&nonSharedCharacterBreakIterator), expected, newValue); I think if you remove the reinterpret_cast here, the build breakage will be fixed.
Filip Pizlo
Comment 4 2015-09-21 21:00:45 PDT
(In reply to comment #3) > Comment on attachment 261712 [details] > the patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=261712&action=review > > r=me with build fix. > > > Source/WebCore/platform/text/TextBreakIterator.cpp:815 > > return WTF::weakCompareAndSwap(reinterpret_cast<void**>(&nonSharedCharacterBreakIterator), expected, newValue); > > I think if you remove the reinterpret_cast here, the build breakage will be > fixed. Yup, that worked!
Filip Pizlo
Comment 5 2015-09-21 21:01:27 PDT
Created attachment 261719 [details] patch for landing
Filip Pizlo
Comment 6 2015-09-21 21:34:56 PDT
Landed in http://trac.webkit.org/changeset/190103
Note You need to log in before you can comment on or make changes to this bug.