Bug 149438

Summary: Always use the compiler's CAS implementation and get rid of ENABLE(COMPARE_AND_SWAP)
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: Web Template FrameworkAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, benjamin, cmarcelo, commit-queue, ggaren, mark.lam, mhahnenb, msaboff, nrotem, oliver, sam, sbarati
Priority: P2    
Version: Other   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 149436    
Attachments:
Description Flags
the patch
none
the patch
mark.lam: review+
patch for landing none

Description Filip Pizlo 2015-09-21 18:05:18 PDT
Patch forthcoming.
Comment 1 Filip Pizlo 2015-09-21 18:12:55 PDT
Created attachment 261710 [details]
the patch
Comment 2 Filip Pizlo 2015-09-21 18:29:51 PDT
Created attachment 261712 [details]
the patch
Comment 3 Mark Lam 2015-09-21 19:33:25 PDT
Comment on attachment 261712 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=261712&action=review

r=me with build fix.

> Source/WebCore/platform/text/TextBreakIterator.cpp:815
>      return WTF::weakCompareAndSwap(reinterpret_cast<void**>(&nonSharedCharacterBreakIterator), expected, newValue);

I think if you remove the reinterpret_cast here, the build breakage will be fixed.
Comment 4 Filip Pizlo 2015-09-21 21:00:45 PDT
(In reply to comment #3)
> Comment on attachment 261712 [details]
> the patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=261712&action=review
> 
> r=me with build fix.
> 
> > Source/WebCore/platform/text/TextBreakIterator.cpp:815
> >      return WTF::weakCompareAndSwap(reinterpret_cast<void**>(&nonSharedCharacterBreakIterator), expected, newValue);
> 
> I think if you remove the reinterpret_cast here, the build breakage will be
> fixed.

Yup, that worked!
Comment 5 Filip Pizlo 2015-09-21 21:01:27 PDT
Created attachment 261719 [details]
patch for landing
Comment 6 Filip Pizlo 2015-09-21 21:34:56 PDT
Landed in http://trac.webkit.org/changeset/190103