| Summary: | [Win] Show tiled drawing debug overlay on Windows | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Brent Fulgham <bfulgham> | ||||
| Component: | Tools / Tests | Assignee: | Brent Fulgham <bfulgham> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | bfulgham, commit-queue, simon.fraser | ||||
| Priority: | P2 | ||||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Brent Fulgham
2015-09-21 15:43:51 PDT
Created attachment 261697 [details]
Patch
Comment on attachment 261697 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=261697&action=review > Source/WebCore/platform/graphics/ca/PlatformCALayer.cpp:99 > +void PlatformCALayer::drawTextAtPoint(CGContextRef context, CGFloat x, CGFloat y, CGPoint scale, CGFloat fontSize, const char* text, size_t length) const Shouldn't a scale be a CGSize? > Source/WebCore/platform/graphics/ca/win/CACFLayerTreeHost.cpp:125 > CACFLayerTreeHost::CACFLayerTreeHost() > - : m_client(0) > - , m_rootLayer(PlatformCALayerWin::create(PlatformCALayer::LayerTypeRootLayer, 0)) > - , m_window(0) > - , m_shouldFlushPendingGraphicsLayerChanges(false) > - , m_isFlushingLayerChanges(false) > -#if !ASSERT_DISABLED > - , m_state(WindowNotSet) > -#endif > + : m_rootLayer(PlatformCALayerWin::create(PlatformCALayer::LayerTypeRootLayer, nullptr)) Nice! Comment on attachment 261697 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=261697&action=review >> Source/WebCore/platform/graphics/ca/PlatformCALayer.cpp:99 >> +void PlatformCALayer::drawTextAtPoint(CGContextRef context, CGFloat x, CGFloat y, CGPoint scale, CGFloat fontSize, const char* text, size_t length) const > > Shouldn't a scale be a CGSize? Sure! I'll change to that. Committed r190091: <http://trac.webkit.org/changeset/190091> |