Bug 149422

Summary:

MediaControlTextTrackContainerElement::createTextTrackRepresentationImage makes an unconditionally unaccelerated ImageBuffer

Product:

WebKit

Reporter:

Tim Horton <thorton>

Component:

Media

Assignee:

Matthew Daiter <mdaiter>

Status:

NEW

Severity:

Normal

CC:

commit-queue, dino, mdaiter, sabouhallawa, simon.fraser

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	simon.fraser: review-, simon.fraser: commit-queue-

Tim Horton

Reported 2015-09-21 15:38:56 PDT

The ImageBuffer should inherit the accelerated bit from the context it will eventually be painted into.

Attachments
Patch (2.25 KB, patch) 2015-12-06 07:08 PST, Matthew Daiter	no flags	Details Formatted Diff Diff
Patch (2.03 KB, patch) 2015-12-06 07:35 PST, Matthew Daiter	no flags	Details Formatted Diff Diff
Patch (2.14 KB, patch) 2015-12-06 07:39 PST, Matthew Daiter	no flags	Details Formatted Diff Diff
Patch (2.15 KB, patch) 2015-12-06 07:41 PST, Matthew Daiter	simon.fraser: review- simon.fraser: commit-queue-	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Matthew Daiter

Comment 1 2015-12-06 07:08:50 PST

Created attachment 266728 [details] Patch

WebKit Commit Bot

Comment 2 2015-12-06 07:11:09 PST

Attachment 266728 [details] did not pass style-queue: ERROR: Source/WebCore/html/shadow/MediaControlElements.cpp:1374: Multi line control clauses should use braces. [whitespace/braces] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.

Matthew Daiter

Comment 3 2015-12-06 07:35:42 PST

Created attachment 266729 [details] Patch

Matthew Daiter

Comment 4 2015-12-06 07:38:46 PST

Realized some might be a bit confused by this block: CanvasCompositingStrategy compositingStrategy = canvasCompositingStrategy(*renderer); if (compositingStrategy != CanvasCompositingStrategy::UnacceleratedCanvas) accelerate = Accelerated; due to its ignorance of UnacceleratedNonPlatformBuffer as a viable option for the value of accelerate. The reasoning behind this is that--upon searching the entire codebase--UnacceleratedNonPlatformBuffer is not used throughout WebCore. Therefore, if the canvas is not unaccelerated, we treat it as accelerated; otherwise, it becomes unaccelerated.

Matthew Daiter

Comment 5 2015-12-06 07:39:56 PST

Created attachment 266730 [details] Patch

Matthew Daiter

Comment 6 2015-12-06 07:41:10 PST

Created attachment 266731 [details] Patch

Simon Fraser (smfr)

Comment 7 2015-12-06 19:41:25 PST

Comment on attachment 266731 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=266731&action=review > Source/WebCore/html/shadow/MediaControlElements.cpp:1373 > + CanvasCompositingStrategy compositingStrategy = canvasCompositingStrategy(*renderer); I'm not sure what you're trying to do here. 'renderer' is not a RenderHTMLCanvas here, but canvasCompositingStrategy asserts that it is. Did you test this in debug?

Note You need to log in before you can comment on or make changes to this bug.