Summary: | Fix warnings in IDLParser.pm | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Csaba Osztrogonác <ossy> | ||||
Component: | New Bugs | Assignee: | Csaba Osztrogonác <ossy> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | cdumez, mcatanzaro, ossy, sam | ||||
Priority: | P2 | ||||||
Version: | Other | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Csaba Osztrogonác
2015-09-21 07:47:36 PDT
Created attachment 261655 [details]
Patch
Comment on attachment 261655 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=261655&action=review r=me with nit > Source/WebCore/bindings/scripts/IDLParser.pm:311 > + } This needs another space of indentation. (In reply to comment #2) > Comment on attachment 261655 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=261655&action=review > > r=me with nit > > > Source/WebCore/bindings/scripts/IDLParser.pm:311 > > + } > > This needs another space of indentation. Good catch, I'll fix it before landing. Committed r190111: <http://trac.webkit.org/changeset/190111> Comment on attachment 261655 [details]
Patch
This looks like this may be papering over a real bug. How can an attribute or parameter not have a type?
It looks like the parser has trouble parsing: [Unscopeable, RaisesException, Custom] void prepend((Node or DOMString)... nodes); [Unscopeable, RaisesException, Custom] void append((Node or DOMString)... nodes); in ParentNode.idl and [Unscopeable, RaisesException, Custom] void before((Node or DOMString)... nodes); [Unscopeable, RaisesException, Custom] void after((Node or DOMString)... nodes); [Unscopeable, RaisesException, Custom] void replaceWith((Node or DOMString)... nodes); in ChildNode.idl Likely the issue is that our parser does not support unions or variadic arguments. Thankfully, even though the parser does not parse them properly, it does not cause problems because we use Custom bindings for these. The proper fix would be to add support for these type of parameters to our IDL parser. FYI, the problem is unions (Node or DOMString). Variadic parameters seem to be fine. (In reply to comment #7) > FYI, the problem is unions (Node or DOMString). Variadic parameters seem to > be fine. Could you file a new bug report for this issue? *** Bug 147132 has been marked as a duplicate of this bug. *** |