Summary: | WTFCrash loading Blink layout test fast/gradients/css3-repeating-radial-gradients-crash.html | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jon Honeycutt <jhoneycutt> | ||||||||||
Component: | CSS | Assignee: | Jiewen Tan <jiewen_tan> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | commit-queue, hyatt, jiewen_tan, webkit-bug-importer | ||||||||||
Priority: | P2 | Keywords: | BlinkMergeCandidate, HasReduction, InRadar | ||||||||||
Version: | Safari 9 | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Jon Honeycutt
2015-09-19 11:11:36 PDT
Created attachment 262223 [details]
Patch
Comment on attachment 262223 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=262223&action=review > Source/WebCore/ChangeLog:13 > + Check whether gradientLength > 0 before using it as nominator. It’s denominator, not nominator. > LayoutTests/fast/gradients/css3-repeating-radial-gradients-crash.html:4 > +Test for crbug.com/295126. If this test passes, no crash occurs. Could you put a WebKit bug URL here instead of the Chromium bug URL please? It would also be better if this was a ref test instead of a render tree dump test. Comment on attachment 262223 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=262223&action=review >> Source/WebCore/ChangeLog:13 >> + Check whether gradientLength > 0 before using it as nominator. > > It’s denominator, not nominator. Sorry for the typo. >> LayoutTests/fast/gradients/css3-repeating-radial-gradients-crash.html:4 >> +Test for crbug.com/295126. If this test passes, no crash occurs. > > Could you put a WebKit bug URL here instead of the Chromium bug URL please? > > It would also be better if this was a ref test instead of a render tree dump test. Sorry for missing the url here. I am not sure whether I know the difference between a ref test and a render tree dump test. Could you give me some references about them? Thank you! Created attachment 262274 [details]
Patch
Created attachment 262464 [details]
Patch
Comment on attachment 262464 [details] Patch Clearing flags on attachment: 262464 Committed r190597: <http://trac.webkit.org/changeset/190597> All reviewed patches have been landed. Closing bug. |