| Summary: | UserMediaClientMock leaks every test run | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Eric Carlson <eric.carlson> | ||||||
| Component: | Media | Assignee: | Eric Carlson <eric.carlson> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, thorton | ||||||
| Priority: | P2 | ||||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Eric Carlson
2015-09-18 16:04:16 PDT
Created attachment 261539 [details]
Proposed patch.
Comment on attachment 261539 [details] Proposed patch. Clearing flags on attachment: 261539 Committed r190001: <http://trac.webkit.org/changeset/190001> All reviewed patches have been landed. Closing bug. This is still leaking, according to the leaks bot. https://bugs.webkit.org/show_bug.cgi?id=149358 made it so that we would only make a UserMediaController if we didn't already have one, so subsequent calls to provideUserMediaTo end up just leaking the client. I think instead of bailing if we already have one, we mean to be replacing it. But also it seems like the memory management surrounding Supplement/friends is quite fragile. I meant https://bugs.webkit.org/show_bug.cgi?id=130311 in the last comment. Created attachment 261608 [details]
patch
|