Bug 149344

Summary: Web Inspector: inspect(aFunction) should jump to function definition
Product: WebKit Reporter: Nikita Vasilyev <nvasilyev>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, graouts, hi, inspector-bugzilla-changes, joepeck, mattbaker, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: All   
OS: All   
See Also: https://bugs.webkit.org/show_bug.cgi?id=175092
Attachments:
Description Flags
[Animated GIF] Chrome DevTools inspect(aFunction)
none
[PATCH] Proposed Fix none

Nikita Vasilyev
Reported 2015-09-18 07:22:37 PDT
Created attachment 261501 [details] [Animated GIF] Chrome DevTools inspect(aFunction) In Chrome, typing inspect(aFunction) in the console navigates to the function definition. I think we should do the same.
Attachments
[Animated GIF] Chrome DevTools inspect(aFunction) (175.50 KB, image/gif)
2015-09-18 07:22 PDT, Nikita Vasilyev 		no flags
Details
[PATCH] Proposed Fix (8.56 KB, patch)
2017-07-21 14:04 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-09-18 07:22:55 PDT
<rdar://problem/22757513>
Joseph Pecoraro
Comment 2 2017-07-21 13:59:17 PDT
<rdar://problem/11563607>
Joseph Pecoraro
Comment 3 2017-07-21 14:04:22 PDT
Created attachment 316118 [details] [PATCH] Proposed Fix
Matt Baker
Comment 4 2017-07-21 15:12:32 PDT
Comment on attachment 316118 [details] [PATCH] Proposed Fix r=me. Nice tests.
Matt Baker
Comment 5 2017-07-21 15:17:01 PDT
I was surprised that the console drawer was shown in addition to the source location. It might be a better experience to leave the console collapsed and just show the source location. inspect(document.head) has the same behavior though, so we should just be consistent.
WebKit Commit Bot
Comment 6 2017-07-21 15:41:30 PDT
Comment on attachment 316118 [details] [PATCH] Proposed Fix Clearing flags on attachment: 316118 Committed r219749: <http://trac.webkit.org/changeset/219749>
WebKit Commit Bot
Comment 7 2017-07-21 15:41:31 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.