| Summary: | Web Inspector: inspect(aFunction) should jump to function definition | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Nikita Vasilyev <nvasilyev> | ||||||
| Component: | Web Inspector | Assignee: | Joseph Pecoraro <joepeck> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, graouts, hi, inspector-bugzilla-changes, joepeck, mattbaker, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Local Build | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=175092 | ||||||||
| Attachments: |
|
||||||||
Created attachment 316118 [details]
[PATCH] Proposed Fix
Comment on attachment 316118 [details]
[PATCH] Proposed Fix
r=me. Nice tests.
I was surprised that the console drawer was shown in addition to the source location. It might be a better experience to leave the console collapsed and just show the source location. inspect(document.head) has the same behavior though, so we should just be consistent. Comment on attachment 316118 [details] [PATCH] Proposed Fix Clearing flags on attachment: 316118 Committed r219749: <http://trac.webkit.org/changeset/219749> All reviewed patches have been landed. Closing bug. |
Created attachment 261501 [details] [Animated GIF] Chrome DevTools inspect(aFunction) In Chrome, typing inspect(aFunction) in the console navigates to the function definition. I think we should do the same.