| Summary: | WebCore shouldn't have to include DFG headers | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Filip Pizlo <fpizlo> | ||||||||
| Component: | JavaScriptCore | Assignee: | Filip Pizlo <fpizlo> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | ap, barraclough, benjamin, commit-queue, ggaren, mark.lam, mhahnenb, msaboff, nrotem, oliver, saam, sam, simon.fraser | ||||||||
| Priority: | P2 | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Filip Pizlo
2015-09-17 22:48:56 PDT
Created attachment 261494 [details]
Patch
Comment on attachment 261494 [details]
Patch
r=me
V. nice. Any way we can prevent inadvertent regressions in future (maybe some include-trap macros?). (In reply to comment #3) > V. nice. > > Any way we can prevent inadvertent regressions in future (maybe some > include-trap macros?). The patch already puts all the DFG header files in the project group (vs private), which has the side effect of making them not reachable from WebCore. If something in WebCore tries to #include them, the build will fail. Created attachment 261662 [details]
patch for landing
Comment on attachment 261662 [details] patch for landing Rejecting attachment 261662 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'build', '--no-clean', '--no-update', '--build-style=release', '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: ailed: CompileC /Volumes/Data/EWS/WebKit/WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/x86_64/AccessibilityMediaControls.o accessibility/AccessibilityMediaControls.cpp normal x86_64 c++ com.apple.compilers.llvm.clang.1_0.compiler CompileC /Volumes/Data/EWS/WebKit/WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/x86_64/AccessibilityRenderObject.o accessibility/AccessibilityRenderObject.cpp normal x86_64 c++ com.apple.compilers.llvm.clang.1_0.compiler (2 failures) Full output: http://webkit-queues.webkit.org/results/193873 Created attachment 261674 [details]
patch for landing
Had to add more fixes for the new tail call code.
Attachment 261674 [details] did not pass style-queue:
ERROR: Source/JavaScriptCore/bytecode/CallLinkInfo.h:321: The parameter name "shuffleData" adds no information, so it should be removed. [readability/parameter_name] [5]
Total errors found: 1 in 10 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 261674 [details]
patch for landing
I'll land manually.
Landed in http://trac.webkit.org/changeset/190073 |