Bug 149330

Summary:

Add some tests for shadow DOM rendering

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

Tools / Tests

Assignee:

Ryosuke Niwa <rniwa>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, eoconnor, koivisto

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

149334, 149365

Bug Blocks:

148695

Attachments:

Description	Flags
Adds some tests	koivisto: review+

Description Ryosuke Niwa 2015-09-17 19:52:46 PDT

Adding some ref tests I've written for rendering the contents that uses new shadow DOM API.

Comment 1 Ryosuke Niwa 2015-09-17 19:56:11 PDT

Created attachment 261476 [details]
Adds some tests

Comment 2 Ryosuke Niwa 2015-09-17 20:08:23 PDT

Committed r189962: <http://trac.webkit.org/changeset/189962>

Comment 3 Alexey Proskuryakov 2015-09-17 21:43:06 PDT

These tests uncovered a bug. Rolling out until it can be fixed.

https://build.webkit.org/results/Apple%20Mavericks%20Debug%20WK1%20(Tests)/r189962%20(15681)/fast/shapes/shape-outside-floats/shape-outside-floats-border-radius-border-box-001-crash-log.txt

https://build.webkit.org/results/Apple%20Mavericks%20Debug%20WK2%20(Tests)/r189962%20(14562)/fast/shapes/shape-outside-floats/shape-outside-dynamic-shape-margin-crash-log.txt

Comment 4 WebKit Commit Bot 2015-09-17 21:44:21 PDT

Re-opened since this is blocked by bug 149334

Comment 5 Alexey Proskuryakov 2015-09-17 21:49:51 PDT

Obviously, the bug is that real work is being done in JSNode destructor.

Comment 6 Ryosuke Niwa 2015-09-21 13:24:17 PDT

Committed r190074: <http://trac.webkit.org/changeset/190074>