Bug 149304 – Heavy taps on links are sometimes interpreted as the preview gesture

• Component: WebKit2
• Status: RESOLVED WONTFIX

[Beth Dakin]

Heavy taps on links are sometimes interpreted as the preview gesture

rdar://problem/22689258

[Beth Dakin]

Created attachment 261439 [details]
Patch

Comment on attachment 261439 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=261439&action=review

> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.h:162
> +    double _lastPreviewStartTime;

Is there a way to use std::chrono types for this instead of a mix of doubles and floats?

> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:3386
> +static const double gMaximumAccidentalPreviewTime = 250;

Probably no need for a named constant for this quantity if it’s only being used once. Definitely no need to use the “g” prefix.

[Tim Horton]

Comment on attachment 261439 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=261439&action=review

>> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.h:162
>> +    double _lastPreviewStartTime;
> 
> Is there a way to use std::chrono types for this instead of a mix of doubles and floats?

Chrono would be good (at the very least, using double everywhere). You can store the time from std::chrono::steady_clock::now() and do something like "std::chrono::duration_cast<std::chrono::milliseconds>(
            std::chrono::steady_clock::now() - _lastPreviewStartTime)" and compare to the literal 250_ms

>> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:3386
>> +static const double gMaximumAccidentalPreviewTime = 250;
> 
> Probably no need for a named constant for this quantity if it’s only being used once. Definitely no need to use the “g” prefix.

Agreed about the g. Don't care if you keep the named constant, but it should at least be inside the function, I guess?

[Beth Dakin]

I rolled this patch out with http://trac.webkit.org/changeset/190284

We're going to try to fix this at a different level.