Bug 149296

Summary: Null dereference loading Blink layout test editing/execCommand/selectAll-including-marquee-crash.html
Product: WebKit Reporter: Jon Honeycutt <jhoneycutt>
Component: HTML EditingAssignee: Jiewen Tan <jiewen_tan>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, jiewen_tan, rniwa, webkit-bug-importer
Priority: P2 Keywords: BlinkMergeCandidate, HasReduction, InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
crashing test
none
Patch none

Jon Honeycutt
Reported 2015-09-17 14:44:40 PDT
Created attachment 261432 [details] crashing test Null dereference loading Blink layout test editing/execCommand/selectAll-including-marquee-crash.html. Stack trace: Crashed Thread: 0 Dispatch queue: com.apple.main-thread Exception Type: EXC_BAD_ACCESS (SIGSEGV) Exception Codes: KERN_INVALID_ADDRESS at 0x0000000000000014 Exception Note: EXC_CORPSE_NOTIFY VM Regions Near 0x14: --> __TEXT 0000000103b4d000-0000000103b4f000 [ 8K] r-x/rwx SM=COW /Users/USER/*/WebKit.framework/Versions/A/XPCServices/com.apple.WebKit.WebContent.Development.xpc/Contents/MacOS/com.apple.WebKit.WebContent.Development Application Specific Information: CRASHING TEST: temp-tests/editing/execCommand/selectAll-including-marquee-crash.html Global Trace Buffer (reverse chronological seconds): 18446743980.859676 CFNetwork 0x00007fff88d43b97 Explicitly setting CF cookie storage singleton 18446743980.860058 CFNetwork 0x00007fff88d8f211 Explicitly setting cookie storage singleton Thread 0 Crashed:: Dispatch queue: com.apple.main-thread 0 com.apple.WebCore 0x000000010b941dcd WebCore::CompositeEditCommand::insertNodeAt(WTF::PassRefPtr<WebCore::Node>, WebCore::Position const&) + 77 (htmlediting.h:103) 1 com.apple.WebCore 0x000000010ba87a58 WebCore::DeleteSelectionCommand::doApply() + 1736 (StdLibExtras.h:366) 2 com.apple.WebCore 0x000000010b94152b WebCore::CompositeEditCommand::applyCommandToComposite(WTF::PassRefPtr<WebCore::EditCommand>) + 43 (CompositeEditCommand.cpp:281) 3 com.apple.WebCore 0x000000010b943dc7 WebCore::CompositeEditCommand::deleteSelection(bool, bool, bool, bool, bool) + 135 (StdLibExtras.h:366) 4 com.apple.WebCore 0x000000010c4f38bc WebCore::ReplaceSelectionCommand::doApply() + 1516 (VisibleSelection.h:70) 5 com.apple.WebCore 0x000000010b941216 WebCore::CompositeEditCommand::apply() + 102 (ScopedEventQueue.h:71) 6 com.apple.WebCore 0x000000010bb77714 WebCore::executeInsertFragment(WebCore::Frame&, WTF::PassRefPtr<WebCore::DocumentFragment>) + 84 (StdLibExtras.h:366) 7 com.apple.WebCore 0x000000010bb74d83 WebCore::executeInsertHTML(WebCore::Frame&, WebCore::Event*, WebCore::EditorCommandSource, WTF::String const&) + 99 (StdLibExtras.h:366) 8 com.apple.WebCore 0x000000010bb73876 WebCore::Editor::Command::execute(WTF::String const&, WebCore::Event*) const + 182 (EditorCommand.cpp:1704) 9 com.apple.WebCore 0x000000010baacc36 WebCore::Document::execCommand(WTF::String const&, bool, WTF::String const&) + 214 (Document.cpp:4666) 10 com.apple.WebCore 0x000000010bec3074 WebCore::jsDocumentPrototypeFunctionExecCommand(JSC::ExecState*) + 420 (JSCJSValue.h:499) 11 ??? 0x0000489437c01028 0 + 79801427693608 12 com.apple.JavaScriptCore 0x000000010b21f76f llint_entry + 22696 13 com.apple.JavaScriptCore 0x000000010b219ce4 vmEntryToJavaScript + 299 14 com.apple.JavaScriptCore 0x000000010b0da2d9 JSC::JITCode::execute(JSC::VM*, JSC::ProtoCallFrame*) + 169 (JITCode.cpp:82) 15 com.apple.JavaScriptCore 0x000000010b0c0a10 JSC::Interpreter::execute(JSC::ProgramExecutable*, JSC::ExecState*, JSC::JSObject*) + 10448 (Interpreter.cpp:945) 16 com.apple.JavaScriptCore 0x000000010add34c5 JSC::evaluate(JSC::ExecState*, JSC::SourceCode const&, JSC::JSValue, WTF::NakedPtr<JSC::Exception>&) + 469 (Completion.cpp:104) 17 com.apple.WebCore 0x000000010c5368ec WebCore::ScriptController::evaluateInWorld(WebCore::ScriptSourceCode const&, WebCore::DOMWrapperWorld&) + 284 (JSMainThreadExecState.h:62) 18 com.apple.WebCore 0x000000010c536b29 WebCore::ScriptController::evaluate(WebCore::ScriptSourceCode const&) + 41 (ScriptController.cpp:180) 19 com.apple.WebCore 0x000000010c53caac WebCore::ScriptElement::executeScript(WebCore::ScriptSourceCode const&) + 316 (ScriptElement.cpp:309) 20 com.apple.WebCore 0x000000010c53b756 WebCore::ScriptElement::prepareScript(WTF::TextPosition const&, WebCore::ScriptElement::LegacyTypeSupport) + 1046 (StdLibExtras.h:366) 21 com.apple.WebCore 0x000000010bd385eb WebCore::HTMLScriptRunner::runScript(WebCore::Element*, WTF::TextPosition const&) + 347 (ScriptElement.h:58) 22 com.apple.WebCore 0x000000010bd38440 WebCore::HTMLScriptRunner::execute(WTF::PassRefPtr<WebCore::Element>, WTF::TextPosition const&) + 48 (HTMLScriptRunner.cpp:191) 23 com.apple.WebCore 0x000000010bcdb466 WebCore::HTMLDocumentParser::runScriptsForPausedTreeBuilder() + 86 (StdLibExtras.h:366) 24 com.apple.WebCore 0x000000010bcdb52d WebCore::HTMLDocumentParser::canTakeNextToken(WebCore::HTMLDocumentParser::SynchronousMode, WebCore::PumpSession&) + 93 (HTMLDocumentParser.cpp:214) 25 com.apple.WebCore 0x000000010bcdb0c3 WebCore::HTMLDocumentParser::pumpTokenizer(WebCore::HTMLDocumentParser::SynchronousMode) + 595 (HTMLDocumentParser.cpp:259) 26 com.apple.WebCore 0x000000010bcdbddd WebCore::HTMLDocumentParser::append(WTF::PassRefPtr<WTF::StringImpl>) + 669 (DocumentParser.h:71) 27 com.apple.WebCore 0x000000010ba7e61c WebCore::DecodedDataDocumentParser::flush(WebCore::DocumentWriter&) + 92 (StdLibExtras.h:366) 28 com.apple.WebCore 0x000000010bade68b WebCore::DocumentWriter::end() + 43 (RefPtr.h:71) 29 com.apple.WebCore 0x000000010bac69ec WebCore::DocumentLoader::finishedLoading(double) + 268 (ResourceErrorBase.h:42) 30 com.apple.WebCore 0x000000010b8f7179 WebCore::CachedResource::checkNotify() + 153 (CachedResourceClientWalker.h:51) 31 com.apple.WebCore 0x000000010b8f3433 WebCore::CachedRawResource::finishLoading(WebCore::SharedBuffer*) + 227 (CachedRawResource.cpp:104) 32 com.apple.WebCore 0x000000010c66e501 WebCore::SubresourceLoader::didFinishLoading(double) + 1153 (ResourceLoader.h:154) 33 com.apple.WebKit 0x000000010a1b498d WebKit::WebResourceLoader::didReceiveWebResourceLoaderMessage(IPC::Connection&, IPC::MessageDecoder&) + 561 (HandleMessage.h:16) 34 com.apple.WebKit 0x0000000109f8e1f1 IPC::Connection::dispatchMessage(std::__1::unique_ptr<IPC::MessageDecoder, std::__1::default_delete<IPC::MessageDecoder> >) + 127 (memory:2636) 35 com.apple.WebKit 0x0000000109f90b4a IPC::Connection::dispatchOneMessage() + 126 (memory:2656) 36 com.apple.JavaScriptCore 0x000000010b3d2985 WTF::RunLoop::performWork() + 437 (functional:1742) 37 com.apple.JavaScriptCore 0x000000010b3d2d32 WTF::RunLoop::performWork(void*) + 34 (RunLoopCF.cpp:39) 38 com.apple.CoreFoundation 0x00007fff949e2c01 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 17 39 com.apple.CoreFoundation 0x00007fff949d4b1c __CFRunLoopDoSources0 + 556 40 com.apple.CoreFoundation 0x00007fff949d403f __CFRunLoopRun + 927 41 com.apple.CoreFoundation 0x00007fff949d3a38 CFRunLoopRunSpecific + 296 42 com.apple.HIToolbox 0x00007fff88e673bd RunCurrentEventLoopInMode + 235 43 com.apple.HIToolbox 0x00007fff88e67153 ReceiveNextEventCommon + 432 44 com.apple.HIToolbox 0x00007fff88e66f93 _BlockUntilNextEventMatchingListInModeWithFilter + 71 45 com.apple.AppKit 0x00007fff870b81e7 _DPSNextEvent + 1076 46 com.apple.AppKit 0x00007fff8748490d -[NSApplication _nextEventMatchingEventMask:untilDate:inMode:dequeue:] + 454 47 com.apple.AppKit 0x00007fff870ae0b8 -[NSApplication run] + 682 48 com.apple.AppKit 0x00007fff87030396 NSApplicationMain + 1176 49 libxpc.dylib 0x00007fff8c70ff70 _xpc_objc_main + 793 50 libxpc.dylib 0x00007fff8c7116bf xpc_main + 494 51 com.apple.WebKit.WebContent.Development 0x0000000103b4e424 main + 409 (XPCServiceMain.Development.mm:187) 52 libdyld.dylib 0x00007fff93aa15ad start + 1
Attachments
crashing test (488 bytes, text/html)
2015-09-17 14:44 PDT, Jon Honeycutt 		no flags
Details
Patch (2.28 KB, patch)
2015-11-09 15:44 PST, Jiewen Tan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-09-17 14:44:56 PDT
<rdar://problem/22746758>
Jiewen Tan
Comment 2 2015-10-27 11:28:14 PDT
The bug is related to Bug 149298.
Jiewen Tan
Comment 3 2015-11-09 15:44:57 PST
Created attachment 265108 [details] Patch
WebKit Commit Bot
Comment 4 2015-11-10 13:55:55 PST
Comment on attachment 265108 [details] Patch Clearing flags on attachment: 265108 Committed r192268: <http://trac.webkit.org/changeset/192268>
WebKit Commit Bot
Comment 5 2015-11-10 13:56:00 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.