Bug 149259

Summary:

REGRESSION: Web Inspector: Double clicking on an attribute second time doesn't work

Product:

WebKit

Reporter:

Nikita Vasilyev <nvasilyev>

Component:

Web Inspector

Assignee:

Joseph Pecoraro <joepeck>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Local Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
[Animated GIF] Bug	none
[PATCH] Proposed Fix	none

Nikita Vasilyev

Reported 2015-09-17 06:14:00 PDT

Created attachment 261389 [details] [Animated GIF] Bug Steps: 1. Open http://nightly.webkit.org/start/trunk/189906 2. Inspect <div id="frame"> (or any other element with an attribute) 3. Double click on id="frame" 4. Click on some other element 5. Double click on id="frame" again Expected: Double clicking the second time enters the editing mode, the same as the first time. Actual: It doesn't enter the editing mode.

Attachments
[Animated GIF] Bug (100.90 KB, image/gif) 2015-09-17 06:14 PDT, Nikita Vasilyev	no flags	Details
[PATCH] Proposed Fix (1.50 KB, patch) 2015-09-17 13:32 PDT, Joseph Pecoraro	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2015-09-17 06:14:14 PDT

<rdar://problem/22737913>

Joseph Pecoraro

Comment 2 2015-09-17 13:14:26 PDT

We are bailing because DOMTreeElement.prototype.ondblclick thinks we are still editing.

Joseph Pecoraro

Comment 3 2015-09-17 13:32:11 PDT

Created attachment 261415 [details] [PATCH] Proposed Fix

WebKit Commit Bot

Comment 4 2015-09-17 14:26:49 PDT

Comment on attachment 261415 [details] [PATCH] Proposed Fix Clearing flags on attachment: 261415 Committed r189933: <http://trac.webkit.org/changeset/189933>

WebKit Commit Bot

Comment 5 2015-09-17 14:26:53 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.