Bug 149252

Summary: [GTK] run-gtk-tests doesn't provide feedback about crashing google tests
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: mcatanzaro, pnormand, zan
Priority: P2 Keywords: Gtk
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch darin: review+

Carlos Garcia Campos
Reported 2015-09-17 01:23:09 PDT
In case of glib tests the test runner notifies about test crashing, but for google tests we don't get any feedback, which means that in case of a test crashign we get a list of **PASS** messages but at the summary we are notified that the test suite has failed: Tests failed (1): bin/TestWebKitAPI/WebKit2/TestWebKit2 But we don't know which test case failed, we would need to check which ones are missing from the output.
Attachments
Patch (1.61 KB, patch)
2015-09-17 01:27 PDT, Carlos Garcia Campos 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2015-09-17 01:27:14 PDT
Created attachment 261376 [details] Patch
Michael Catanzaro
Comment 2 2015-09-17 05:38:00 PDT
SIGTRAP is another quite common crash signal. There are many less-common signals that can crash the program, but I guess we can't test for them all....
Carlos Garcia Campos
Comment 3 2015-09-21 00:28:39 PDT
Committed r190046: <http://trac.webkit.org/changeset/190046>
Note You need to log in before you can comment on or make changes to this bug.