Summary: | Drop support for Entity Node type | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||||||||
Component: | DOM | Assignee: | Chris Dumez <cdumez> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | achristensen, ap, buildbot, commit-queue, darin, rniwa, sam, webkit-bug-importer | ||||||||||||
Priority: | P2 | Keywords: | InRadar, WebExposed | ||||||||||||
Version: | Other | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
URL: | https://dom.spec.whatwg.org/#dom-core-changes | ||||||||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=149348 | ||||||||||||||
Attachments: |
|
Description
Chris Dumez
2015-09-16 16:56:38 PDT
Created attachment 261339 [details]
Patch
Doesn't seem to apply on TOT. Created attachment 261346 [details]
Patch
Attachment 261346 [details] did not pass style-queue:
ERROR: Source/WebCore/dom/Node.h:136: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
Total errors found: 1 in 8 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 261346 [details] Patch Attachment 261346 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/177976 New failing tests: http/tests/security/cross-frame-access-put.html js/dom/global-constructors-attributes.html Created attachment 261352 [details]
Archive of layout-test-results from ews104 for mac-mavericks-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
Comment on attachment 261346 [details] Patch Attachment 261346 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/178014 New failing tests: http/tests/security/cross-frame-access-put.html http/tests/security/cross-frame-access-getOwnPropertyDescriptor.html js/dom/global-constructors-attributes.html Created attachment 261354 [details]
Archive of layout-test-results from ews103 for mac-mavericks
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103 Port: mac-mavericks Platform: Mac OS X 10.9.5
Created attachment 261359 [details]
Patch
Attachment 261359 [details] did not pass style-queue:
ERROR: Source/WebCore/dom/Node.h:136: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
Total errors found: 1 in 9 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 261359 [details] Patch Clearing flags on attachment: 261359 Committed r189971: <http://trac.webkit.org/changeset/189971> All reviewed patches have been landed. Closing bug. CMake clean builds fixed in http://trac.webkit.org/changeset/189988 |