Bug 149239

Summary: Drop support for Entity Node type
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, ap, buildbot, commit-queue, darin, rniwa, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar, WebExposed
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
URL: https://dom.spec.whatwg.org/#dom-core-changes
See Also: https://bugs.webkit.org/show_bug.cgi?id=149348
Attachments:
Description Flags
Patch
none
Patch
none
Archive of layout-test-results from ews104 for mac-mavericks-wk2
none
Archive of layout-test-results from ews103 for mac-mavericks
none
Patch none

Chris Dumez
Reported 2015-09-16 16:56:38 PDT
Drop support for Entity DOM type. This legacy type has been dropped in DOM4: https://dom.spec.whatwg.org/#dom-core-changes Chrome [1] and Firefox [2] already dropped it. There is currently no way to construct an Entity Node in WebKit. [1] https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/k3tZGP2EANc [2] https://developer.mozilla.org/en-US/docs/Web/API/Entity
Attachments
Patch (35.51 KB, patch)
2015-09-16 17:05 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (35.33 KB, patch)
2015-09-16 18:30 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews104 for mac-mavericks-wk2 (787.14 KB, application/zip)
2015-09-16 19:23 PDT, Build Bot 		no flags
Details
Archive of layout-test-results from ews103 for mac-mavericks (795.03 KB, application/zip)
2015-09-16 19:43 PDT, Build Bot 		no flags
Details
Patch (56.33 KB, patch)
2015-09-16 20:34 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2015-09-16 17:05:53 PDT
Created attachment 261339 [details] Patch
Ryosuke Niwa
Comment 2 2015-09-16 18:23:30 PDT
Doesn't seem to apply on TOT.
Chris Dumez
Comment 3 2015-09-16 18:30:47 PDT
Created attachment 261346 [details] Patch
WebKit Commit Bot
Comment 4 2015-09-16 18:32:04 PDT
Attachment 261346 [details] did not pass style-queue: ERROR: Source/WebCore/dom/Node.h:136: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Total errors found: 1 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.
Build Bot
Comment 5 2015-09-16 19:23:07 PDT
Comment on attachment 261346 [details] Patch Attachment 261346 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/177976 New failing tests: http/tests/security/cross-frame-access-put.html js/dom/global-constructors-attributes.html
Build Bot
Comment 6 2015-09-16 19:23:11 PDT
Created attachment 261352 [details] Archive of layout-test-results from ews104 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
Build Bot
Comment 7 2015-09-16 19:43:42 PDT
Comment on attachment 261346 [details] Patch Attachment 261346 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/178014 New failing tests: http/tests/security/cross-frame-access-put.html http/tests/security/cross-frame-access-getOwnPropertyDescriptor.html js/dom/global-constructors-attributes.html
Build Bot
Comment 8 2015-09-16 19:43:46 PDT
Created attachment 261354 [details] Archive of layout-test-results from ews103 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-mavericks Platform: Mac OS X 10.9.5
Chris Dumez
Comment 9 2015-09-16 20:34:01 PDT
Created attachment 261359 [details] Patch
WebKit Commit Bot
Comment 10 2015-09-16 20:36:54 PDT
Attachment 261359 [details] did not pass style-queue: ERROR: Source/WebCore/dom/Node.h:136: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Total errors found: 1 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 11 2015-09-18 10:23:34 PDT
Comment on attachment 261359 [details] Patch Clearing flags on attachment: 261359 Committed r189971: <http://trac.webkit.org/changeset/189971>
WebKit Commit Bot
Comment 12 2015-09-18 10:23:40 PDT
All reviewed patches have been landed. Closing bug.
Alex Christensen
Comment 13 2015-09-18 15:27:58 PDT
CMake clean builds fixed in http://trac.webkit.org/changeset/189988
Radar WebKit Bug Importer
Comment 14 2015-09-28 11:47:41 PDT
<rdar://problem/22882670>
Note You need to log in before you can comment on or make changes to this bug.