| Summary: | Convert return values from JavaScript functions to the expected types in WebAssembly | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Sukolsak Sakshuwong <sukolsak> | ||||||||||||
| Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | commit-queue, fpizlo, ggaren, mark.lam, saam, sukolsak, ysuzuki | ||||||||||||
| Priority: | P2 | ||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Bug Depends on: | |||||||||||||||
| Bug Blocks: | 146064 | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Sukolsak Sakshuwong
2015-09-15 17:56:04 PDT
Created attachment 261274 [details]
Patch
Created attachment 261276 [details]
Patch
Created attachment 261277 [details]
Patch
Created attachment 261385 [details]
Patch
Comment on attachment 261385 [details]
Patch
r=me
Comment on attachment 261385 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=261385&action=review r=me with a comment > Source/JavaScriptCore/wasm/WASMFunctionCompiler.h:109 > + // FIXME: No need to do type conversion if the caller is a WebAssembly function. lets open a bug for this (if there isn't already one) and link it here. > Source/JavaScriptCore/wasm/WASMFunctionCompiler.h:984 > + // FIXME: No need to do type conversion if the callee is a WebAssembly function. Let's open a bug for this if there isn't one and link it here. Created attachment 261449 [details] Update to ToT and add a link to https://bugs.webkit.org/show_bug.cgi?id=149310 Comment on attachment 261449 [details] Update to ToT and add a link to https://bugs.webkit.org/show_bug.cgi?id=149310 Clearing flags on attachment: 261449 Committed r189946: <http://trac.webkit.org/changeset/189946> All reviewed patches have been landed. Closing bug. |