Bug 149193 – GraphicsContext::drawBidiText()'s BidiResolver should not have isolated runs

• Component: New Bugs
• Status: RESOLVED FIXED

[Myles C. Maxfield]

GraphicsContext::drawBidiText()'s BidiResolver should not have isolated runs

[Myles C. Maxfield]

Created attachment 261255 [details]
Patch

[Anders Carlsson]

Comment on attachment 261255 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=261255&action=review

> Source/WebCore/platform/text/BidiResolver.h:304
> +class BidiResolver: public BidiResolverBase<Iterator, Run, BidiResolver<Iterator, Run>> {

Space before :

> Source/WebCore/platform/text/BidiResolver.h:309
> +class BidiResolverWithIsolate: public BidiResolverBase<Iterator, Run, BidiResolverWithIsolate<Iterator, Run, IsolateRun>> {

Space before :

> Source/WebCore/rendering/InlineIterator.h:444
> +template <>

No space!

> Source/WebCore/rendering/InlineIterator.h:532
>  template <>

Shouldn't have a space here either.

Aren’t isolated runs needed for supporting explicit directional isolates (LRI, RLI and FSI)? See <http://www.unicode.org/reports/tr9/#Explicit_Directional_Isolates>.

[Myles C. Maxfield]

Mitz: Yep, but we don't honor those currently. I filed a bug about it recently: https://bugs.webkit.org/show_bug.cgi?id=149170

[Myles C. Maxfield]

(In reply to comment #4)
> Mitz: Yep, but we don't honor those currently. I filed a bug about it
> recently: https://bugs.webkit.org/show_bug.cgi?id=149170

At least, I should say that our isolate infrastructure requires isolates to come from RenderElements. (Maybe we generate RenderElements for these codepoints and I've just not seen where we do that).

See constructBidiRunsForSegment().

[Myles C. Maxfield]

Committed r189829: <http://trac.webkit.org/changeset/189829>