Summary: | JS Function removed after parsing | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Rodney Rehm <mail> | ||||
Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED WORKSFORME | ||||||
Severity: | Normal | CC: | amichal, fpizlo, ggaren, hartman.wiki, mathias, nvasilyev, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Rodney Rehm
2015-09-15 11:29:20 PDT
*** This bug has been marked as a duplicate of bug 126337 *** (In reply to comment #2) > > *** This bug has been marked as a duplicate of bug 126337 *** Note that this is not really a duplicate of bug 126337. Fixing bug 126337 would work around the issue in this specific case of `CSS.escape` but the underlying JavaScriptCore bug would still be there. Oh, you're right. Sorry about that. It isn't about WebKit missing CSS.escape. It is about a bizarre WebKit behavior with this particular CSS.escape shim. We encountered the same issue (with the same polyfill) in Wikipedia/MediaWiki. Issue was tracked: https://phabricator.wikimedia.org/T121991 You can also reproduce it be delaying the lookup with a setTimeout. The code below alerts('window.CSS.escape missing in event') in Version 9.1 (10601.5.17.4) <html> <script src='css.escape.js'></script> <script type='text/javascript'> if (!window.CSS.escape) { alert('window.CSS.escape not loaded'); } console.log(!!window.CSS.escape); setTimeout(function() { console.log(!!window.CSS.escape); if (!window.CSS.escape) { alert('window.CSS.escape missing in event'); } },5000); </script> </html> I can't get this to reproduce in WebKit trunk right anymore. Please reopen if you can get it to fail in trunk, nightly, etc. Created attachment 278255 [details]
patch that has the regression test
Comment on attachment 278255 [details]
patch that has the regression test
rs=me if it bots don't complain.
Confirmed. Still broken in Safari Version 9.1 (11601.5.17.1), but works in STP Version 9.1.1 (11601.6.17, 11602.1.29). |