Bug 149172

Summary: [GTK] Build failure with ACCELERATED_2D_CANVAS when cairo-gl has built with OpenGLESv2 support only
Product: WebKit Reporter: Carlos Alberto Lopez Perez <clopez>
Component: WebKitGTKAssignee: Carlos Alberto Lopez Perez <clopez>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, commit-queue, mcatanzaro, mrobinson
Priority: P2    
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Carlos Alberto Lopez Perez 2015-09-15 11:05:06 PDT 
cairo-gl can be built with full OpenGL support or with OpenGLESv2 support.

When cairo-gl is built with only OpenGLESv2 support, cairo-glx is not enabled.

If then webkitgtk+ is built with GLX (full OpenGL) support and with it ACCELERATED_2D_CANVAS support the following build error would happen:

Source/WebCore/platform/graphics/glx/GLContextGLX.cpp:270:74: error: 'cairo_glx_device_create' was not declared in this scope
make[2]: *** [Source/WebCore/CMakeFiles/WebCorePlatformGTK.dir/platform/graphics/glx/GLContextGLX.cpp.o] Error 1
Comment 1 Carlos Alberto Lopez Perez 2015-09-15 11:08:26 PDT 
Created attachment 261217 [details]
Patch
Comment 2 WebKit Commit Bot 2015-09-15 14:50:32 PDT 
Comment on attachment 261217 [details]
Patch

Clearing flags on attachment: 261217

Committed r189826: <http://trac.webkit.org/changeset/189826>
Comment 3 WebKit Commit Bot 2015-09-15 14:50:36 PDT 
All reviewed patches have been landed.  Closing bug.