Bug 149172

Summary: [GTK] Build failure with ACCELERATED_2D_CANVAS when cairo-gl has built with OpenGLESv2 support only
Product: WebKit Reporter: Carlos Alberto Lopez Perez <clopez>
Component: WebKitGTKAssignee: Carlos Alberto Lopez Perez <clopez>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, commit-queue, mcatanzaro, mrobinson
Priority: P2    
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Carlos Alberto Lopez Perez
Reported 2015-09-15 11:05:06 PDT
cairo-gl can be built with full OpenGL support or with OpenGLESv2 support. When cairo-gl is built with only OpenGLESv2 support, cairo-glx is not enabled. If then webkitgtk+ is built with GLX (full OpenGL) support and with it ACCELERATED_2D_CANVAS support the following build error would happen: Source/WebCore/platform/graphics/glx/GLContextGLX.cpp:270:74: error: 'cairo_glx_device_create' was not declared in this scope make[2]: *** [Source/WebCore/CMakeFiles/WebCorePlatformGTK.dir/platform/graphics/glx/GLContextGLX.cpp.o] Error 1
Attachments
Patch (1.49 KB, patch)
2015-09-15 11:08 PDT, Carlos Alberto Lopez Perez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Alberto Lopez Perez
Comment 1 2015-09-15 11:08:26 PDT
Created attachment 261217 [details] Patch
WebKit Commit Bot
Comment 2 2015-09-15 14:50:32 PDT
Comment on attachment 261217 [details] Patch Clearing flags on attachment: 261217 Committed r189826: <http://trac.webkit.org/changeset/189826>
WebKit Commit Bot
Comment 3 2015-09-15 14:50:36 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.