Bug 149151

Summary: [GTK] Extend default timeout value for release build.
Product: WebKit Reporter: ChangSeok Oh <changseok>
Component: WebKitGTKAssignee: ChangSeok Oh <changseok>
Status: RESOLVED WONTFIX    
Severity: Normal CC: cgarcia, commit-queue, glenn, gustavo, mrobinson, pnormand, zan
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 149112    
Attachments:
Description Flags
Patch changseok: review-

ChangSeok Oh
Reported 2015-09-14 21:45:51 PDT
Currently the default value of timeout for release build is 6000ms. But this is too short to pass some media tests. For example, ./LayoutTests/media/media-controls-timeline-updates.html and mine posted in bug149112. Those tests wait until a video play is done. However, the used video's runtime is 6.02 second so it fails with timeout. Thus, I propose to extend the default value to 7000ms.
Attachments
Patch (2.44 KB, patch)
2015-09-14 21:50 PDT, ChangSeok Oh 		changseok: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
ChangSeok Oh
Comment 1 2015-09-14 21:50:04 PDT
Created attachment 261170 [details] Patch
Philippe Normand
Comment 2 2015-09-14 23:55:17 PDT
This seems more like a workaround. Shouldn't the test be fixed instead?
Philippe Normand
Comment 3 2015-09-14 23:56:05 PDT
Instead of waiting normal playback is finished you should seek to video.duration - someSmallValue.
ChangSeok Oh
Comment 4 2015-09-15 00:16:43 PDT
(In reply to comment #3) > Instead of waiting normal playback is finished you should seek to > video.duration - someSmallValue. Well, it could be. but it sounds more like a workaround. The video has been used for a long time. there are many testes using it already. IMHO, fixing the test itself is not a good idea to avoid timeout for a specific port. Fixing the tests itself requires extra effort. Also, it is hard to believe for somebody working on other port to add some extra code manipulating runtime for gtk port in a his/her new test.
Philippe Normand
Comment 5 2015-09-15 00:33:13 PDT
(In reply to comment #3) > Instead of waiting normal playback is finished you should seek to > video.duration - someSmallValue. This is (or used to be) a common technique in the media tests, fwiw. Doesn't feel like a workaround to me, we need tests to finish as fast as possible, waiting 6 or 7 seconds for a single test is bad if it can be easily avoided.
ChangSeok Oh
Comment 6 2015-09-16 00:43:59 PDT
(In reply to comment #5) > (In reply to comment #3) > > Instead of waiting normal playback is finished you should seek to > > video.duration - someSmallValue. > > This is (or used to be) a common technique in the media tests, fwiw. Doesn't > feel like a workaround to me, we need tests to finish as fast as possible, > waiting 6 or 7 seconds for a single test is bad if it can be easily avoided. O.K. I modified my test for bug149112. media-controls-timeline-updates.html should be changed later as well.
Note You need to log in before you can comment on or make changes to this bug.