Summary: | [GTK] Extend default timeout value for release build. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | ChangSeok Oh <changseok> | ||||
Component: | WebKitGTK | Assignee: | ChangSeok Oh <changseok> | ||||
Status: | RESOLVED WONTFIX | ||||||
Severity: | Normal | CC: | cgarcia, commit-queue, glenn, gustavo, mrobinson, pnormand, zan | ||||
Priority: | P2 | ||||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 149112 | ||||||
Attachments: |
|
Description
ChangSeok Oh
2015-09-14 21:45:51 PDT
Created attachment 261170 [details]
Patch
This seems more like a workaround. Shouldn't the test be fixed instead? Instead of waiting normal playback is finished you should seek to video.duration - someSmallValue. (In reply to comment #3) > Instead of waiting normal playback is finished you should seek to > video.duration - someSmallValue. Well, it could be. but it sounds more like a workaround. The video has been used for a long time. there are many testes using it already. IMHO, fixing the test itself is not a good idea to avoid timeout for a specific port. Fixing the tests itself requires extra effort. Also, it is hard to believe for somebody working on other port to add some extra code manipulating runtime for gtk port in a his/her new test. (In reply to comment #3) > Instead of waiting normal playback is finished you should seek to > video.duration - someSmallValue. This is (or used to be) a common technique in the media tests, fwiw. Doesn't feel like a workaround to me, we need tests to finish as fast as possible, waiting 6 or 7 seconds for a single test is bad if it can be easily avoided. (In reply to comment #5) > (In reply to comment #3) > > Instead of waiting normal playback is finished you should seek to > > video.duration - someSmallValue. > > This is (or used to be) a common technique in the media tests, fwiw. Doesn't > feel like a workaround to me, we need tests to finish as fast as possible, > waiting 6 or 7 seconds for a single test is bad if it can be easily avoided. O.K. I modified my test for bug149112. media-controls-timeline-updates.html should be changed later as well. |