Bug 149146

Summary: new Event() without parameter should throw
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, buildbot, commit-queue, rniwa, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar, WebExposed
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
URL: https://dom.spec.whatwg.org/#interface-event
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews104 for mac-mavericks-wk2
none
Archive of layout-test-results from ews101 for mac-mavericks
none
Patch none

Description Chris Dumez 2015-09-14 19:28:30 PDT 
new Event() without parameter should throw because the type parameter is mandatory as per the specification:
https://dom.spec.whatwg.org/#interface-event

Both Firefox and Chrome throw in this case. WebKit creates an event whose type is the string "undefined".
Comment 1 Chris Dumez 2015-09-14 19:29:03 PDT 
rdar://problem/22565070
Comment 2 Chris Dumez 2015-09-14 19:32:24 PDT 
Created attachment 261162 [details]
Patch
Comment 3 Build Bot 2015-09-14 20:15:59 PDT 
Comment on attachment 261162 [details]
Patch

Attachment 261162 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/172003

New failing tests:
fast/dom/constructed-objects-prototypes.html
Comment 4 Build Bot 2015-09-14 20:16:03 PDT 
Created attachment 261164 [details]
Archive of layout-test-results from ews104 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5
Comment 5 Build Bot 2015-09-14 20:30:02 PDT 
Comment on attachment 261162 [details]
Patch

Attachment 261162 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/172031

New failing tests:
fast/dom/constructed-objects-prototypes.html
Comment 6 Build Bot 2015-09-14 20:30:05 PDT 
Created attachment 261165 [details]
Archive of layout-test-results from ews101 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-mavericks  Platform: Mac OS X 10.9.5
Comment 7 Chris Dumez 2015-09-14 23:01:40 PDT 
Created attachment 261177 [details]
Patch
Comment 8 WebKit Commit Bot 2015-09-15 15:11:09 PDT 
Comment on attachment 261177 [details]
Patch

Clearing flags on attachment: 261177

Committed r189827: <http://trac.webkit.org/changeset/189827>
Comment 9 WebKit Commit Bot 2015-09-15 15:11:14 PDT 
All reviewed patches have been landed.  Closing bug.