| Summary: | Polish code for r189579. | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | dewei_zhu | ||||||
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | cdumez, commit-queue, darin | ||||||
| Priority: | P2 | ||||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
dewei_zhu
2015-09-14 14:41:32 PDT
Please use a revision, not a bug number and use 'r' before the number. Created attachment 261130 [details]
Patch
Comment on attachment 261130 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=261130&action=review r=me with comments. > Source/WebCore/ChangeLog:9 > + "characterSetForBindings". And optimize the way to get text encoding. This is a fix for bug 148810. Don't start the sentence with "And". Also try to wrap your ChangeLog at ~80 characters. > Source/WebCore/dom/Document.h:1751 > + if (TextResourceDecoder *d = decoder()) Star on wrong side, also, you can use auto* Also, don't use 'd', no abbreviated names. Created attachment 261145 [details]
Patch
Comment on attachment 261145 [details] Patch Rejecting attachment 261145 [details] from commit-queue. dewei_zhu@apple.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights. Comment on attachment 261145 [details] Patch Rejecting attachment 261145 [details] from commit-queue. dewei_zhu@apple.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights. Comment on attachment 261145 [details] Patch Clearing flags on attachment: 261145 Committed r189771: <http://trac.webkit.org/changeset/189771> All reviewed patches have been landed. Closing bug. |