Summary: | Drop non-standard [IsIndex] WebKit IDL extended attribute | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||
Component: | Bindings | Assignee: | Chris Dumez <cdumez> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | ap, darin, ggaren, rniwa, sam, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar, WebExposed | ||||||
Version: | Other | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Chris Dumez
2015-09-14 11:16:40 PDT
Created attachment 261117 [details]
Patch
Created attachment 261121 [details]
Patch
Comment on attachment 261121 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=261121&action=review > Source/WebCore/ChangeLog:27 > + for negative values and we know the value around instead, as other typo here: "we know the value around" but we mean "we now wrap the value around". This bug is really titled wrong. The real issue here is the change in behavior for these negative indexes. We are changing the behavior to match changes in the specifications and other browsers. As you can see, the old behavior was required by older DOM specifications. Changing the behavior removes the need for [IsIndex]. Actually dropping [IsIndex] is a cleanup step and less interesting, so shouldn’t be the bug title. Committed r189770: <http://trac.webkit.org/changeset/189770> (In reply to comment #5) > This bug is really titled wrong. The real issue here is the change in > behavior for these negative indexes. We are changing the behavior to match > changes in the specifications and other browsers. As you can see, the old > behavior was required by older DOM specifications. > > Changing the behavior removes the need for [IsIndex]. Actually dropping > [IsIndex] is a cleanup step and less interesting, so shouldn’t be the bug > title. Sorry, I saw this comment after committing. You're right. I actually did not initially realize this used to be expected behavior. I have always known Web IDL to wrap around. |