Bug 149118

Summary: Rename current concrete IDB implementation to "Legacy"
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebCore Misc.Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue
Priority: P2    
Version: Safari 9   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 149117    
Attachments:
Description Flags
Patch v1
none
Patch v2
none
Patch v3 achristensen: review+

Description Brady Eidson 2015-09-14 10:16:09 PDT
Rename current concrete IDB implementation to "Legacy"

By virtualization the DOM binding classes and making the current concrete implementations be legacy implementations, the current implementation can live side-by-side with the new implementation tracked by https://bugs.webkit.org/show_bug.cgi?id=149117
Comment 1 Brady Eidson 2015-09-14 11:28:30 PDT
Created attachment 261116 [details]
Patch v1
Comment 2 WebKit Commit Bot 2015-09-14 11:30:54 PDT
Attachment 261116 [details] did not pass style-queue:


ERROR: Source/WebCore/Modules/indexeddb/IDBObjectStore.h:92:  The parameter name "context" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/Modules/indexeddb/IDBObjectStore.h:92:  The parameter name "ec" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/CMakeLists.txt:866:  There should be exactly one empty line instead of 0 between "Modules/indexeddb/WorkerGlobalScopeIndexedDatabase.cpp" and "Modules/indexeddb/legacy/IDBCursorBackend.cpp".  [list/emptyline] [5]
ERROR: Source/WebCore/Modules/indexeddb/IDBCursor.h:72:  The parameter name "ec" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/Modules/indexeddb/IDBIndex.h:59:  The parameter name "context" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/Modules/indexeddb/IDBIndex.h:59:  The parameter name "ec" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/Modules/indexeddb/IDBIndex.h:60:  The parameter name "context" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/Modules/indexeddb/IDBIndex.h:60:  The parameter name "keyRange" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/Modules/indexeddb/IDBIndex.h:60:  The parameter name "ec" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/Modules/indexeddb/IDBIndex.h:61:  The parameter name "context" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/Modules/indexeddb/IDBIndex.h:61:  The parameter name "ec" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/Modules/indexeddb/IDBIndex.h:65:  The parameter name "context" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/Modules/indexeddb/IDBIndex.h:65:  The parameter name "ec" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/Modules/indexeddb/IDBIndex.h:69:  The parameter name "context" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/Modules/indexeddb/IDBIndex.h:69:  The parameter name "ec" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/Modules/indexeddb/IDBIndex.h:70:  The parameter name "context" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/Modules/indexeddb/IDBIndex.h:70:  The parameter name "keyRange" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/Modules/indexeddb/IDBIndex.h:70:  The parameter name "ec" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/Modules/indexeddb/IDBIndex.h:71:  The parameter name "context" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/Modules/indexeddb/IDBIndex.h:71:  The parameter name "ec" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/Modules/indexeddb/legacy/IDBPendingTransactionMonitor.cpp:27:  You should add a blank line after implementation file's own header.  [build/include_order] [4]
ERROR: Source/WebCore/Modules/indexeddb/legacy/IDBPendingTransactionMonitor.cpp:46:  Missing space before {  [whitespace/braces] [5]
ERROR: Source/WebCore/Modules/indexeddb/legacy/IDBTransactionBackendOperations.cpp:154:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/Modules/indexeddb/legacy/IDBTransactionBackendOperations.cpp:177:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/Modules/indexeddb/legacy/IDBTransactionBackendOperations.cpp:193:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/Modules/indexeddb/legacy/IDBTransactionBackendOperations.cpp:211:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/Modules/indexeddb/legacy/IDBTransactionBackendOperations.cpp:247:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/Modules/indexeddb/legacy/LegacyTransaction.cpp:202:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/WebCore/Modules/indexeddb/legacy/LegacyTransaction.cpp:203:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/Modules/indexeddb/legacy/LegacyAny.cpp:34:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/Modules/indexeddb/legacy/LegacyAny.cpp:36:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/Modules/indexeddb/legacy/IDBCursorBackendOperations.cpp:43:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/Modules/indexeddb/legacy/IDBCursorBackendOperations.cpp:68:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/Modules/indexeddb/legacy/LegacyCursor.cpp:37:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 34 in 78 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Brady Eidson 2015-09-14 13:11:20 PDT
Created attachment 261125 [details]
Patch v2
Comment 4 WebKit Commit Bot 2015-09-14 13:14:02 PDT
Attachment 261125 [details] did not pass style-queue:


ERROR: Source/WebCore/Modules/indexeddb/IDBIndex.h:60:  The parameter name "keyRange" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/Modules/indexeddb/IDBIndex.h:70:  The parameter name "keyRange" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/Modules/indexeddb/legacy/IDBTransactionBackendOperations.cpp:154:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/Modules/indexeddb/legacy/IDBTransactionBackendOperations.cpp:177:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/Modules/indexeddb/legacy/IDBTransactionBackendOperations.cpp:193:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/Modules/indexeddb/legacy/IDBTransactionBackendOperations.cpp:211:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/Modules/indexeddb/legacy/IDBTransactionBackendOperations.cpp:247:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/Modules/indexeddb/legacy/IDBCursorBackendOperations.cpp:42:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/Modules/indexeddb/legacy/IDBCursorBackendOperations.cpp:67:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 9 in 79 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Brady Eidson 2015-09-14 13:40:11 PDT
Created attachment 261128 [details]
Patch v3
Comment 6 WebKit Commit Bot 2015-09-14 13:43:16 PDT
Attachment 261128 [details] did not pass style-queue:


ERROR: Source/WebCore/Modules/indexeddb/IDBIndex.h:60:  The parameter name "keyRange" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/Modules/indexeddb/IDBIndex.h:70:  The parameter name "keyRange" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/Modules/indexeddb/legacy/IDBTransactionBackendOperations.cpp:154:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/Modules/indexeddb/legacy/IDBTransactionBackendOperations.cpp:177:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/Modules/indexeddb/legacy/IDBTransactionBackendOperations.cpp:193:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/Modules/indexeddb/legacy/IDBTransactionBackendOperations.cpp:211:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/Modules/indexeddb/legacy/IDBTransactionBackendOperations.cpp:247:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/Modules/indexeddb/legacy/IDBCursorBackendOperations.cpp:42:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/Modules/indexeddb/legacy/IDBCursorBackendOperations.cpp:67:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 9 in 81 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Brady Eidson 2015-09-14 14:02:24 PDT
https://trac.webkit.org/changeset/189746