Summary: | Improve Node pre-insertion validation when the parent is a Document | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||||
Component: | DOM | Assignee: | Chris Dumez <cdumez> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | ap, buildbot, commit-queue, esprehn+autocc, kangil.han, rniwa, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar, WebExposed | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
URL: | https://dom.spec.whatwg.org/#concept-node-ensure-pre-insertion-validity | ||||||||||
Attachments: |
|
Description
Chris Dumez
2015-09-13 20:09:43 PDT
Created attachment 261093 [details]
Patch
Comment on attachment 261093 [details] Patch Attachment 261093 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/169071 New failing tests: userscripts/mixed-case-stylesheet.html Created attachment 261096 [details]
Archive of layout-test-results from ews104 for mac-mavericks-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
Created attachment 261097 [details]
Patch
Comment on attachment 261097 [details]
Patch
r=me assuming all tests pass and there is no performance regression from this change
(check Dromaeo & Speedometer).
(In reply to comment #6) > Comment on attachment 261097 [details] > Patch > > r=me assuming all tests pass and there is no performance regression from > this change > (check Dromaeo & Speedometer). Ok, I'll check the benchmarks before landing. I wasn't too worried because this change only affects inserting a direct child to the Document. You cannot insert a lot of those, especially Doctype / Element (just one of each). Comment on attachment 261097 [details] Patch Clearing flags on attachment: 261097 Committed r189682: <http://trac.webkit.org/changeset/189682> All reviewed patches have been landed. Closing bug. |