Bug 149090

Summary: [Win][HighDPI] Windowed plugins have incorrect placement.
Product: WebKit Reporter: peavo
Component: WebKit Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, commit-queue
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description peavo 2015-09-12 01:00:40 PDT 
We have to scale with device scale factor.
Comment 1 peavo 2015-09-12 01:23:48 PDT 
Created attachment 261051 [details]
Patch
Comment 2 peavo 2015-09-14 07:44:48 PDT 
(In reply to comment #1)
> Created attachment 261051 [details]
> Patch

This patch needs a little tweaking, it also affects the placements of windowless plugins, which already have correct placement ... :)
Comment 3 Alex Christensen 2015-09-14 11:12:29 PDT 
Comment on attachment 261051 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=261051&action=review

> Source/WebKit/win/Plugins/PluginViewWin.cpp:961
> +    FrameView& frameView = downcast<FrameView>(*parent());

Is the parent always non-null and always a FrameView?
Comment 4 peavo 2015-09-14 12:29:35 PDT 
(In reply to comment #3)
> Comment on attachment 261051 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=261051&action=review
> 
> > Source/WebKit/win/Plugins/PluginViewWin.cpp:961
> > +    FrameView& frameView = downcast<FrameView>(*parent());
> 
> Is the parent always non-null and always a FrameView?

Thanks for reviewing :)

This is a good point, I'm not sure. I will put an assert there and test.
Comment 5 peavo 2015-09-17 09:53:29 PDT 
Created attachment 261393 [details]
Patch
Comment 6 Alex Christensen 2015-09-17 10:35:31 PDT 
Comment on attachment 261393 [details]
Patch

r=me.  Thanks!
Comment 7 peavo 2015-09-17 11:09:32 PDT 
(In reply to comment #6)
> Comment on attachment 261393 [details]
> Patch
> 
> r=me.  Thanks!

Thanks for reviewing :)
Comment 8 WebKit Commit Bot 2015-09-17 11:23:11 PDT 
Comment on attachment 261393 [details]
Patch

Clearing flags on attachment: 261393

Committed r189919: <http://trac.webkit.org/changeset/189919>
Comment 9 WebKit Commit Bot 2015-09-17 11:23:16 PDT 
All reviewed patches have been landed.  Closing bug.