Bug 149089

Summary: Web Inspector: Extract InspectorFrontendAPI dispatching from WebInspectorUI
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: DoNotImportToRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix none

Description Joseph Pecoraro 2015-09-11 22:00:01 PDT 
* SUMMARY
Extract InspectorFrontendAPI dispatching from WebInspectorUI.

This makes it more readable and able to share.
Comment 1 Joseph Pecoraro 2015-09-11 22:00:43 PDT 
Created attachment 261044 [details]
[PATCH] Proposed Fix
Comment 2 WebKit Commit Bot 2015-09-11 22:02:07 PDT 
Attachment 261044 [details] did not pass style-queue:


ERROR: Source/WebKit2/WebProcess/WebPage/WebInspectorFrontendAPIDispatcher.h:38:  The parameter name "page" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 BJ Burg 2015-09-12 11:13:56 PDT 
Comment on attachment 261044 [details]
[PATCH] Proposed Fix

r=me, nice!
Comment 4 WebKit Commit Bot 2015-09-12 12:02:29 PDT 
Comment on attachment 261044 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 261044

Committed r189657: <http://trac.webkit.org/changeset/189657>
Comment 5 WebKit Commit Bot 2015-09-12 12:02:33 PDT 
All reviewed patches have been landed.  Closing bug.