Bug 149086

Summary: Whitespace underlines are not repainted on color changes
Product: WebKit Reporter: Philip Rogers <pdr>
Component: CSSAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: ahmad.saleem792, bfulgham, fujii.hironori, karlcow, kling, mmaxfield, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Repro for webkit none

Philip Rogers
Reported 2015-09-11 21:22:05 PDT
Created attachment 261042 [details] Repro for webkit wkrev.com/150259 introduced a small regression where text decorations such as underlines are not repainted for whitespace text. A user recently reported this against Chrome and I had merged the above patch a few years ago so we shared this bug. I fixed this by removing the whitespace check which keeps the original optimization but causes whitespace runs to be repainted. My fix landed in https://src.chromium.org/viewvc/blink?revision=202164&view=revision and a similar fix would work in WebKit too.
Attachments
Repro for webkit (876 bytes, text/html)
2015-09-11 21:22 PDT, Philip Rogers 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2015-09-12 21:13:56 PDT
This repro is fantastic, thank you!
Brent Fulgham
Comment 2 2022-07-14 14:44:40 PDT
WebKit still gets this wrong, 7 years later.
Radar WebKit Bug Importer
Comment 3 2022-07-14 14:44:49 PDT
<rdar://problem/97036299>
Ahmad Saleem
Comment 4 2022-10-16 10:59:44 PDT
I think this change should be here: https://github.com/WebKit/WebKit/blob/main/Source/WebCore/rendering/RenderElement.cpp#L319 Replacing "isAllCollapsibleWhitespace" with equivalent of "isBR".
Fujii Hironori
Comment 5 2024-01-16 17:27:44 PST
This is not reproducible with Safari 17.2.1 and STP 186 to me.
Ahmad Saleem
Comment 6 2024-01-16 17:31:55 PST
(In reply to Fujii Hironori from comment #5) > This is not reproducible with Safari 17.2.1 and STP 186 to me. Yes - I can't reproduce it as well. Might be fixed between 2022 to 2024 now.
Fujii Hironori
Comment 7 2024-01-16 17:33:30 PST
Thank you for the confirmation. Closed.
Note You need to log in before you can comment on or make changes to this bug.