Bug 149085

Summary: window.EventTarget should exist
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, buildbot, commit-queue, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar, WebExposed
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews103 for mac-mavericks
none
Archive of layout-test-results from ews107 for mac-mavericks-wk2
none
Patch
none
Archive of layout-test-results from ews101 for mac-mavericks
none
Archive of layout-test-results from ews107 for mac-mavericks-wk2
none
Patch none

Description Chris Dumez 2015-09-11 17:10:11 PDT 
window.EventTarget should exist. As per the DOM specification, EventTarget is an interface and it does not have the [NoInterfaceObject] IDL extended attribute:
https://dom.spec.whatwg.org/#interface-eventtarget

Therefore, there should be a property with the same name on the global Window object.
Comment 1 Chris Dumez 2015-09-11 17:10:38 PDT 
rdar://problem/22546774
Comment 2 Chris Dumez 2015-09-11 17:13:14 PDT 
Created attachment 261036 [details]
Patch
Comment 3 Build Bot 2015-09-11 17:54:01 PDT 
Comment on attachment 261036 [details]
Patch

Attachment 261036 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/161464

New failing tests:
js/dom/global-constructors-attributes.html
Comment 4 Build Bot 2015-09-11 17:54:04 PDT 
Created attachment 261038 [details]
Archive of layout-test-results from ews103 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-mavericks  Platform: Mac OS X 10.9.5
Comment 5 Build Bot 2015-09-11 18:26:55 PDT 
Comment on attachment 261036 [details]
Patch

Attachment 261036 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/161504

New failing tests:
js/dom/global-constructors-attributes.html
Comment 6 Build Bot 2015-09-11 18:26:58 PDT 
Created attachment 261040 [details]
Archive of layout-test-results from ews107 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5
Comment 7 Chris Dumez 2015-09-12 10:56:45 PDT 
Created attachment 261057 [details]
Patch
Comment 8 Build Bot 2015-09-12 11:55:49 PDT 
Comment on attachment 261057 [details]
Patch

Attachment 261057 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/165249

New failing tests:
js/dom/global-constructors-attributes.html
Comment 9 Build Bot 2015-09-12 11:55:53 PDT 
Created attachment 261060 [details]
Archive of layout-test-results from ews101 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-mavericks  Platform: Mac OS X 10.9.5
Comment 10 Build Bot 2015-09-12 12:01:53 PDT 
Comment on attachment 261057 [details]
Patch

Attachment 261057 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/165256

New failing tests:
js/dom/global-constructors-attributes.html
Comment 11 Build Bot 2015-09-12 12:01:58 PDT 
Created attachment 261061 [details]
Archive of layout-test-results from ews107 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5
Comment 12 Chris Dumez 2015-09-12 12:40:29 PDT 
Created attachment 261063 [details]
Patch
Comment 13 WebKit Commit Bot 2015-09-12 14:52:38 PDT 
Comment on attachment 261063 [details]
Patch

Clearing flags on attachment: 261063

Committed r189660: <http://trac.webkit.org/changeset/189660>
Comment 14 WebKit Commit Bot 2015-09-12 14:52:44 PDT 
All reviewed patches have been landed.  Closing bug.