Bug 149082

Summary: http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-overridesexpires.html is flaky
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: youennf
Priority: P2 Keywords: LayoutTestFailure
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=150378

Description Alexey Proskuryakov 2015-09-11 16:53:17 PDT
http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-overridesexpires.html flakily fails on slower bots:

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Fxmlhttprequest%2Ftimeout%2Fxmlhttprequest-timeout-overridesexpires.html

-PASS XHR2 Timeout Property Tests 
-PASS XHR2 Timeout Property Tests 1 
+FAIL XHR2 Timeout Property Tests assert_equals: timeout set to expiring value after load fires, original timeout at 1000, reset at 800 to 200 expected "load" but got "timeout"(stack: assert@http://127.0.0.1:8000/w3c/resources/testharness.js:2060:37
+assert_equals@http://127.0.0.1:8000/w3c/resources/testharness.js:699:15
+http://127.0.0.1:8000/xmlhttprequest/timeout/xmlhttprequest-timeout-runner.js:7:40
+step@http://127.0.0.1:8000/w3c/resources/testharness.js:1160:30
+test@http://127.0.0.1:8000/w3c/resources/testharness.js:443:22
+testResultCallbackHandler@http://127.0.0.1:8000/xmlhttprequest/timeout/xmlhttprequest-timeout-runner.js:7:13)
 
This is not very recent, it happened on August 22nd (and possibly before that).
Comment 1 Alexey Proskuryakov 2015-09-11 16:55:48 PDT
Marked as flaky in r189638.
Comment 2 youenn fablet 2015-09-14 07:29:52 PDT
Will have a look at it, probably next week.

FWIW, the timeouts of the corresponding W3C tests got increased 5x, probably for similar reasons (https://github.com/w3c/web-platform-tests/commit/b74228224b0411069050cb81b3d74fc205c59339).

I guess doing so might increase the risk of getting timeouting tests for all xmlhttprequest/timeout tests if not updating TestExpectations.
We might want to try increasing timeouts, by 2x or 3x.
Comment 3 youenn fablet 2016-01-04 00:52:49 PST
WebKit xmlhttprequest-timeout-overridesexpires.html was removed in favor of WPT version which is not flaky (increased timeouts).