Bug 149063

Summary: [GTK] [Stable] Build failure at GLContextEGL.cpp on 2.8.5
Product: WebKit Reporter: Carlos Alberto Lopez Perez <clopez>
Component: WebKitGTKAssignee: Carlos Alberto Lopez Perez <clopez>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, cgarcia, commit-queue, mario
Priority: P2    
Version: Other   
Hardware: Other   
OS: Linux   
Attachments:
Description Flags
Patch mario: review+

Description Carlos Alberto Lopez Perez 2015-09-11 05:55:36 PDT 
While trying to build WebKitGTK+ 2.8.5 with Yocto/OpenEmbedded (With GLESv2) I get this error:

/home/clopez/cea/yocto/buildporter/tmp/work/cortexa15hf-vfp-neon-poky-linux-gnueabi/webkit2-gtk/2.8.5-r0/webkitgtk-2.8.5/Source/WebCore/platform/graphics/egl/GLContextEGL.cpp:194:91: error: 'DefaultRootWindow' was not declared in this scope
/home/clopez/cea/yocto/buildporter/tmp/work/cortexa15hf-vfp-neon-poky-linux-gnueabi/webkit2-gtk/2.8.5-r0/webkitgtk-2.8.5/Source/WebCore/platform/graphics/egl/GLContextEGL.cpp:194:105: error: 'XCreatePixmap' was not declared in this scope
/home/clopez/cea/yocto/buildporter/tmp/work/cortexa15hf-vfp-neon-poky-linux-gnueabi/webkit2-gtk/2.8.5-r0/webkitgtk-2.8.5/Source/WebCore/platform/graphics/egl/GLContextEGL.cpp:202:47: error: 'XFreePixmap' was not declared in this scope
/home/clopez/cea/yocto/buildporter/tmp/work/cortexa15hf-vfp-neon-poky-linux-gnueabi/webkit2-gtk/2.8.5-r0/webkitgtk-2.8.5/Source/WebCore/platform/graphics/egl/GLContextEGL.cpp:276:49: error: 'XFreePixmap' was not declared in this scope
make[2]: *** [Source/WebCore/CMakeFiles/WebCorePlatformGTK.dir/platform/graphics/egl/GLContextEGL.cpp.o] Error 1
make[1]: *** [Source/WebCore/CMakeFiles/WebCorePlatformGTK.dir/all] Error 2
Comment 1 Carlos Alberto Lopez Perez 2015-09-11 06:02:31 PDT 
Created attachment 261004 [details]
Patch

Patch for stable (2.8.5).
Comment 2 WebKit Commit Bot 2015-09-11 06:04:55 PDT 
Attachment 261004 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/egl/GLContextEGL.cpp:44:  "X11/Xlib.h" already included at Source/WebCore/platform/graphics/egl/GLContextEGL.cpp:40  [build/include] [4]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Carlos Alberto Lopez Perez 2015-09-11 06:09:03 PDT 
(In reply to comment #2)
> Attachment 261004 [details] did not pass style-queue:
> 
> 
> ERROR: Source/WebCore/platform/graphics/egl/GLContextEGL.cpp:44: 
> "X11/Xlib.h" already included at
> Source/WebCore/platform/graphics/egl/GLContextEGL.cpp:40  [build/include] [4]
> Total errors found: 1 in 2 files
> 
> 
> If any of these errors are false positives, please file a bug against
> check-webkit-style.

This is checking against trunk, which already includes this change.
The patch is for the stable branch.
Ignore this warning.