Bug 149046

Summary:

WebInspectorUI should have a WebPage reference

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

Web Inspector

Assignee:

Joseph Pecoraro <joepeck>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer

Priority:

Keywords:

DoNotImportToRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
[PATCH] Proposed Fix	none

Description Joseph Pecoraro 2015-09-10 15:01:39 PDT

* SUMMARY
WebInspectorUI should have a WebPage reference.

No need for a pointer, the WebPage's lifetime surrounds this object's lifetime.

I did not do the same to WebKit::WebInspector, because that is an API::Object and someone could extend the lifetime (although I don't think we would handle that case properly if it did happen.

Comment 1 Joseph Pecoraro 2015-09-10 15:02:21 PDT

Created attachment 260959 [details]
[PATCH] Proposed Fix

Comment 2 Geoffrey Garen 2015-09-10 17:55:17 PDT

Comment on attachment 260959 [details]
[PATCH] Proposed Fix

r=me

Comment 3 WebKit Commit Bot 2015-09-10 18:42:20 PDT

Comment on attachment 260959 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 260959

Committed r189601: <http://trac.webkit.org/changeset/189601>

Comment 4 WebKit Commit Bot 2015-09-10 18:42:24 PDT

All reviewed patches have been landed.  Closing bug.