Bug 14902

Summary:

Fix build for JavaScriptCore with qt4

Product:

WebKit

Reporter:

Paul Nasrat <pnasrat>

Component:

JavaScriptCore

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

523.x (Safari 3)

Hardware:

OS:

Linux

Attachments:

Description	Flags
Change Unicode::toUpper declaration	ggaren: review+

Paul Nasrat

Reported 2007-08-08 05:38:03 PDT

Changeset 24919 broke building with qt4 ../../../JavaScriptCore/kjs/string_object.cpp:725: error: invalid conversion from ‘const UChar*’ to ‘UChar*’ ../../../JavaScriptCore/kjs/string_object.cpp:725: error: initializing argument 3 of ‘int WTF::Unicode::toUpper(UChar*, int, UChar*, int, bool*)’ ../../../JavaScriptCore/kjs/string_object.cpp:728: error: invalid conversion from ‘const UChar*’ to ‘UChar*’

Attachments
Change Unicode::toUpper declaration (593 bytes, patch) 2007-08-08 05:39 PDT, Paul Nasrat	ggaren: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Paul Nasrat

Comment 1 2007-08-08 05:39:54 PDT

Created attachment 15866 [details] Change Unicode::toUpper declaration This patch makes the qt4 Unicode::toUpper declaration take a const UChar* to mirror toLower.

Geoffrey Garen

Comment 2 2007-08-08 08:41:48 PDT

Comment on attachment 15866 [details] Change Unicode::toUpper declaration r=me

George Staikos

Comment 3 2007-08-08 09:33:03 PDT

Best to file Qt bugs in the qt component next time so I see them. I already have a fix for this (identical).

Note You need to log in before you can comment on or make changes to this bug.